Bumped install-nix-action to v23 #1087
Conversation
:-( |
.github/workflows/build-with-nix.yml
Outdated
| pull_request: | ||
| branches: | ||
| - main | ||
| - develop | ||
| push: | ||
| branches: | ||
| - develop |
There was a problem hiding this comment.
Once we have it working, I'd prefer not to have this as it could take quite a while to run. Let's just keep it on the weekly schedule (+ possible manual trigger) that we have now.
|
I can confirm that I've now added the The issue is happening in the same place as it was on macos13 before the dylib flat namespace patch. I cannot determine whether the issue is the macos version or the CPU architecture. So this leaves three main options. One is to resolve the underlying issue, which is that typecast.hpp contains implementation, and that is included into two separate compilation units and is causing the symbol collision. I'm not sure how much pybind11 constrains this, as I believe that implementation does need to be provided in a header. One is to identify why the vanilla cmake build is working - what's different? Should it be working? Another is to identify the platforms this currently does work on, and then restrict the support matrix accordingly. This doesn't sound ideal, but might serve as a point to improve on over time. |
All those sound like good options, but for now, if it works on macos-13, I'm happy to just change the platform used in the workflow to |
|
This is now ready for final review |
cqc-alec
force-pushed
the
update-nix-install-action
branch
from
8ac42c6
to
4083e47
Compare
…ot compatible with System Identity Protection
…ather than macos12
…a diverted store is not supported on this platform' error
…ving cmake debug messages that were used to determine that cmake was detecting the OS correctly
… and corrected cached directory to /nix/store rather than /nix
…ctions/cache runs into permissions problems on the nix store
…sions abilities and the target matrix that we'll need. Github's own actions/cache runs into permissions issues and fails to rebuild the nix store. Determinate Systems' magic nix cache relies on a download that doesn't exist for ARM macos. Long term we should investigate using a public cache (e.g. cachix or host our own) that not only speeds up CI, but also speeds up the process of installing tket for users
…caching is sorted
cqc-alec
force-pushed
the
update-nix-install-action
branch
from
4083e47
to
fa29291
Compare
This is because the original version (v20) was not compatible with System Identity Protection on Macos