Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytket extensions index page to pytket API docs #1105

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Oct 31, 2023

Currently the pytket-extensions repo currently only contains the source for a single documentation page.

I was going to put this page in the tket-site repository but this requires adding an additonal build stage. I think that adding a whole extra build for a single index page is a bit overkill

I think it is much simpler to just have the extensions index as part of the pytket API docs. This is already linked from the API docs anyway.

Note that most of the links go to the relevant API docs at the https://tket.quantinuum.com domain.

The pytket-qujax, pytket-ionq, pytket-aqt and pytket-qsharp docs are not yet built on the website so the links for these extensions go to the cqcl.github.io site.

@CalMacCQ
Copy link
Contributor Author

CalMacCQ commented Oct 31, 2023

Looks like there are some warnings from duplicate links that are casuing the docs build to fail on ubuntu.

https://github.com/CQCL/tket/actions/runs/6710330796/job/18235282076?pr=1105

EDIT: now solved in 8999f27.


.. toctree::
:caption: More Documentation:
:maxdepth: 1

Manual <https://cqcl.github.io/pytket/manual/index.html>
Extensions <https://cqcl.github.io/pytket-extensions/api/index.html>
extensions_index.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if this is showing up as intended? Do we want to update the links back from the extensions to this overview as well?

Copy link
Contributor Author

@CalMacCQ CalMacCQ Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what it looks like before and after I click (see images below). I would like to avoid the dropdown as this looks really bad.

Any ideas how to fix this?

I've tried the following

.. toctree::
    :caption: More Documentation:
    :maxdepth: 0

But that doesn't work

Screenshot 2023-10-31 at 18 50 33

Screenshot 2023-10-31 at 18 50 23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown looks not like the best solution, but showing them always is taking a lot of space also... Do you have any other ideas how to handle this?


QPUs
====
`IBMQBackend <https://tket.quantinuum.com/extensions/pytket-qiskit/api.html#pytket.extensions.qiskit.IBMQBackend>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which order are the QPUs sorted here?

Copy link
Contributor Author

@CalMacCQ CalMacCQ Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are now in this order

Screenshot 2023-10-31 at 18 55 00

I have now put Quantinuum first and mentioned that H2-1 is supported and H1-2 is not. Is this correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought they are all three now available? I think we should list all three

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H1-2 is retired from my understanding.

Is there another one besides H1-1 and H2-1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the H1-2 can be left out.

@CalMacCQ CalMacCQ merged commit 02b7a62 into develop Nov 2, 2023
31 checks passed
@CalMacCQ CalMacCQ deleted the docs/add_extensions_index branch November 2, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants