Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip non-module libraries when generating stubs. #1121

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

cqc-alec
Copy link
Collaborator

For some reason pkgutil is including these libraries in its modules list (with latest version on Linux).

Also apply black formatting (first commit here).

@cqc-alec cqc-alec requested a review from trvto November 13, 2023 10:22
Copy link
Contributor

@trvto trvto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trvto
Copy link
Contributor

trvto commented Nov 13, 2023

Could consider moving the mypy checks to macos-13 runners?

@trvto
Copy link
Contributor

trvto commented Nov 13, 2023

Could consider moving the mypy checks to macos-13 runners?

Since they run much faster and would therefore also give earlier feedback

@cqc-alec
Copy link
Collaborator Author

Could consider moving the mypy checks to macos-13 runners?

Yes, that would be good.

@cqc-alec cqc-alec merged commit 2215735 into develop Nov 13, 2023
31 checks passed
@cqc-alec cqc-alec deleted the bugfix/stubskip branch November 13, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants