Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1132 update nix macos compiler #1133

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jake-arkinstall
Copy link
Contributor

The solution to bug #1132 was fortunately very simple. Nixpkgs has recently bumped the default darwin clang from 11 to 16, which resolved the C++ compilation issue.

Additionally, nixpkgs has updated python3.10 to python3.11. A change required to build pytket was to encode the python version into a module path rather than hardcoding python3.10, so that's useful for longevity.

nix flake check has been run on my m2 macbook and on my linux machine, and both pass on this branch.

jake-arkinstall and others added 2 commits November 20, 2023 12:58
…ccount, rather than hardcoding 3.10 (as the prior commit updated to python3.11)
@cqc-alec cqc-alec merged commit 8a3da30 into develop Nov 20, 2023
27 checks passed
@cqc-alec cqc-alec deleted the bugfix/1132-update-nix-macos-compiler branch November 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants