Bugfix/1132 update nix macos compiler #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default macos compiler
…ccount, rather than hardcoding 3.10 (as the prior commit updated to python3.11)
cqc-alec
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution to bug #1132 was fortunately very simple. Nixpkgs has recently bumped the default darwin clang from 11 to 16, which resolved the C++ compilation issue.
Additionally, nixpkgs has updated python3.10 to python3.11. A change required to build pytket was to encode the python version into a module path rather than hardcoding python3.10, so that's useful for longevity.
nix flake check has been run on my m2 macbook and on my linux machine, and both pass on this branch.