Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy support to nix builds of pytket #1138

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

jake-arkinstall
Copy link
Contributor

The previous nix derivations for pytket did not include the .pyi files for the _tket directory. This meant that mypy checks could not establish the type information for the binders. With this PR, those files are included and mypy runs successfully. I have thus added mypy checks to the checkPhase of pytket.

This issue was discovered when running mypy checks on a local pytket-qir clone I'm working on adding nix support to.

I have also .gitignored the 'result' directory, in case someone runs nix build .#[package] from within the source directory.

…s on pytket and the tests into the checkPhase of the pytket nix derivation. Added result directory to .gitignore incase anyone runs nix build in the source directory.
@cqc-alec cqc-alec merged commit 8d84e19 into develop Nov 22, 2023
28 checks passed
@cqc-alec cqc-alec deleted the feature/nix-support-add-mypy branch November 22, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants