Add mypy support to nix builds of pytket #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on pytket and the tests into the checkPhase of the pytket nix derivation. Added result directory to .gitignore incase anyone runs nix build in the source directory.
cqc-alec
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous nix derivations for pytket did not include the .pyi files for the _tket directory. This meant that mypy checks could not establish the type information for the binders. With this PR, those files are included and mypy runs successfully. I have thus added mypy checks to the checkPhase of pytket.
This issue was discovered when running mypy checks on a local pytket-qir clone I'm working on adding nix support to.
I have also .gitignored the 'result' directory, in case someone runs
nix build .#[package]from within the source directory.