Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytket.zx dependency issue #1168

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Dec 11, 2023

Description

There was an issue with the tensor_from_mixed_diagram function in the pytket.zx module. This was due to a new release of the quimb package version 1.7.0.

The 1.7.0 release dropped the opt_einsum dependency casuing the error. It seems there is now equivalent functionality in the cotengra package under the name of greedy instead of random-greedy.

Please summarise the changes.

Related issues

See the build failure in CQCL/pytket-docs#279

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@CalMacCQ CalMacCQ changed the title change random-greedy to greedy Fix pytket.zx dependency issue Dec 11, 2023
@CalMacCQ CalMacCQ marked this pull request as draft December 11, 2023 14:08
@CalMacCQ CalMacCQ marked this pull request as ready for review December 12, 2023 12:30
@CalMacCQ CalMacCQ merged commit c14aabe into develop Dec 12, 2023
28 checks passed
@CalMacCQ CalMacCQ deleted the bugfix/pytket.zx_dependency branch December 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants