Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add a Circuit method for Reset #1184

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Dec 18, 2023

Commonly used enough that having to switch to add_gate confuses people.

Commonly used enough that having to switch to add_gate confuses people.
@ss2165 ss2165 requested a review from cqc-melf December 18, 2023 10:29
@ss2165
Copy link
Member Author

ss2165 commented Dec 18, 2023

I'm not sure what is causing the CI failures, any pointers are appreciated

cqc-melf
cqc-melf previously approved these changes Dec 19, 2023
Copy link
Contributor

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any examples in which we want to add this?

@ss2165
Copy link
Member Author

ss2165 commented Dec 19, 2023

@cqc-melf
Copy link
Contributor

You need to update the version in the binders as well: https://github.com/CQCL/tket/blob/feature/reset-method/pytket/conanfile.py#L35

But I am not sure if that solves the problem.

If you need help I could take a more detailed look later today

@cqc-melf cqc-melf changed the base branch from main to develop December 19, 2023 17:28
@@ -471,20 +471,6 @@ class Circuit:
:return: the new :py:class:`Circuit`
"""
@typing.overload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stub generation removes this, will look into this again tomorrow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think I mistakenly put those in manually, should be taken out and generated I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be working now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ss2165 ss2165 merged commit a031a2f into develop Dec 20, 2023
30 checks passed
@ss2165 ss2165 deleted the feature/reset-method branch December 20, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants