[feature] add a Circuit method for Reset #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commonly used enough that having to switch to add_gate confuses people.
|
I'm not sure what is causing the CI failures, any pointers are appreciated |
cqc-melf
previously approved these changes
Dec 19, 2023
|
|
You need to update the version in the binders as well: https://github.com/CQCL/tket/blob/feature/reset-method/pytket/conanfile.py#L35 But I am not sure if that solves the problem. If you need help I could take a more detailed look later today |
cqc-melf
reviewed
Dec 19, 2023
pytket/pytket/_tket/circuit.pyi
Outdated
| @@ -471,20 +471,6 @@ class Circuit: | |||
| :return: the new :py:class:`Circuit` | |||
| """ | |||
| @typing.overload | |||
There was a problem hiding this comment.
The stub generation removes this, will look into this again tomorrow.
There was a problem hiding this comment.
yes I think I mistakenly put those in manually, should be taken out and generated I think?
cqc-melf
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonly used enough that having to switch to add_gate confuses people.