Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse "stale" Pauli stabilizers when generating Pauli graphs #1245

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Feb 9, 2024

Description

Fixes a bug in applying PhasedX gates as sequences of Rz and Rx gates.

Related issues

Fixes #1244 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec marked this pull request as ready for review February 9, 2024 09:38
@cqc-alec cqc-alec requested review from yao-cqc and removed request for sjdilkes February 9, 2024 11:56
GIVEN("A PhasedX gate") {
// https://github.com/CQCL/tket/issues/1244
Circuit c(1);
c.add_op<unsigned>(OpType::PhasedX, {0.5, 0.6}, {0});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for completeness, we could add another gate to test for a Clifford angle of beta (just switch the angles). Otherwise this all looks good to me!

@cqc-alec cqc-alec merged commit fc89c70 into develop Feb 9, 2024
30 checks passed
@cqc-alec cqc-alec deleted the bugfix/pauliexp branch February 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PauliExponentials pass changes circuit semantics
2 participants