-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lark
package instead of deprecated lark-parser
#1386
Conversation
lark
package instead of deprecated lark-parser
Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits. |
Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits. |
1 similar comment
Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits. |
Keeping the old hash can confuse nix and make it use the wrong package - it's usually best to give the hash an empty string on an update. Then the build fails, but it tells you what the hash should have been. Additionally the latest versions of lark use pyproject formatting rather than a setup.py process, so buildPythonPackage needs to be told to use that. I've adjusted that and committed the change. |
@jake-arkinstall-quantinuum Oops I think I just force-pushed over your change sorry. I was hoping it would tell me the correct hash. Please could you fix again? Thanks! |
Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits. |
No worries, I should have warned you! I'll patch it now. |
Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits. |
Compiler PytketIBMQ is best, or equal best on, 15.78947368421052% for circuits. |
Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits. |
Happy to approve this, are the nix questions sorted @jake-arkinstall @cqc-alec ? |
Yes, I am happy with the nix side here |
…231) - the `lark-parser` dependency was removed due to an updated of TKET as well (CQCL/tket#1386)
Description
Needs a couple of small tweaks to the qasm and quipper parsers.
Related issues
Closes #1356 .
Checklist