Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lark package instead of deprecated lark-parser #1386

Merged
merged 5 commits into from
May 10, 2024
Merged

Use lark package instead of deprecated lark-parser #1386

merged 5 commits into from
May 10, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented May 9, 2024 •
edited
Loading

Description

Needs a couple of small tweaks to the qasm and quipper parsers.

Related issues

Closes #1356 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec changed the title Larkupdate Use lark package instead of deprecated lark-parser May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@jake-arkinstall
Copy link
Contributor

Keeping the old hash can confuse nix and make it use the wrong package - it's usually best to give the hash an empty string on an update. Then the build fails, but it tells you what the hash should have been.

Additionally the latest versions of lark use pyproject formatting rather than a setup.py process, so buildPythonPackage needs to be told to use that. I've adjusted that and committed the change.

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented May 9, 2024

Keeping the old hash can confuse nix and make it use the wrong package - it's usually best to give the hash an empty string on an update. Then the build fails, but it tells you what the hash should have been.

Additionally the latest versions of lark use pyproject formatting rather than a setup.py process, so buildPythonPackage needs to be told to use that. I've adjusted that and committed the change.

@jake-arkinstall-quantinuum Oops I think I just force-pushed over your change sorry. I was hoping it would tell me the correct hash. Please could you fix again? Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@jake-arkinstall
Copy link
Contributor

Keeping the old hash can confuse nix and make it use the wrong package - it's usually best to give the hash an empty string on an update. Then the build fails, but it tells you what the hash should have been.
Additionally the latest versions of lark use pyproject formatting rather than a setup.py process, so buildPythonPackage needs to be told to use that. I've adjusted that and committed the change.

@jake-arkinstall-quantinuum Oops I think I just force-pushed over your change sorry. I was hoping it would tell me the correct hash. Please could you fix again? Thanks!

No worries, I should have warned you! I'll patch it now.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 15.78947368421052% for circuits.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@cqc-alec cqc-alec requested a review from cqc-melf May 9, 2024 15:48
@cqc-alec cqc-alec marked this pull request as ready for review May 9, 2024 15:48
@cqc-melf
Copy link
Contributor

cqc-melf commented May 9, 2024

Happy to approve this, are the nix questions sorted @jake-arkinstall @cqc-alec ?

@jake-arkinstall
Copy link
Contributor

Yes, I am happy with the nix side here

@cqc-alec cqc-alec merged commit 23bb57e into main May 10, 2024
32 checks passed
@cqc-alec cqc-alec deleted the larkupdate branch May 10, 2024 06:47
@cqc-alec cqc-alec mentioned this pull request May 13, 2024
Merged
@nquetschlich nquetschlich mentioned this pull request May 24, 2024
Merged
nquetschlich added a commit to cda-tum/mqt-predictor that referenced this pull request May 24, 2024
@nquetschlich
🚨 fixed warnings that occurred due to new pytket and qiskit version (#…
5eca242 
…231)

- the `lark-parser` dependency was removed due to an updated of TKET as
well (CQCL/tket#1386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-melf cqc-melf cqc-melf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating lark-parser depedency to lark
3 participants
@cqc-alec @jake-arkinstall @cqc-melf