Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow constant BitLogicExp as condition #1397

Merged
merged 3 commits into from
May 15, 2024
Merged

Allow constant BitLogicExp as condition #1397

merged 3 commits into from
May 15, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented May 15, 2024 •
edited
Loading

Closes #1383 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec changed the title Feature/bitlogicexpconst Allow constant BitLogicExp as condition May 15, 2024
@cqc-alec cqc-alec requested a review from yao-cqc May 15, 2024 14:17
@cqc-alec cqc-alec marked this pull request as ready for review May 15, 2024 14:17
@github-actions GitHub Actions
Copy link

Compiler PytketIBMQ is best, or equal best on, 15.78947368421052% for circuits.

@github-actions GitHub Actions
Copy link

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@yao-cqc
Copy link
Contributor

yao-cqc commented May 15, 2024

So BitWiseOp.ONE means if True and BitWiseOp.ONE means if False? I don't quite understand.

@cqc-alec
Copy link
Collaborator Author

So BitWiseOp.ONE means if True and BitWiseOp.ONE means if False? I don't quite understand.

Yes that's right.

@cqc-alec cqc-alec merged commit 4df750b into main May 15, 2024
32 checks passed
@cqc-alec cqc-alec deleted the feature/bitlogicexpconst branch May 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-cqc yao-cqc yao-cqc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add constants for BitLogicExp
2 participants
@cqc-alec @yao-cqc