Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any kwarg type. #1500

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Allow any kwarg type. #1500

merged 2 commits into from
Jul 30, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jul 23, 2024

Closes #868 .

I don't see a good reason for the restriction, and extensions sometimes want to pass other types such as dictionaries.

@yao-cqc yao-cqc merged commit da1f491 into main Jul 30, 2024
30 checks passed
@yao-cqc yao-cqc deleted the ae/kwargtypes branch July 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax typing restriction on KwargTypes = Union[int, float, str, None]
2 participants