-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove types setuptools and release 1.31 #1512
Conversation
Tries to solve #1513 |
pytket/docs/changelog.rst
Outdated
|
||
* remove types-pkg_resources dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GIven that the removal of this package from pypi renders pytket uninstallable I think we should announce this more prominently in the docs. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do this in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should do that. Feel free to make a second PR for that.
Looks like we might be in luck here - have you also tried installing in a fresh local environment where we can be sure there's no lingering installation of |
Co-authored-by: Silas Dilkes <36165522+sjdilkes@users.noreply.github.com>
A couple of thoughts of potential relevance:
|
Yes I did that:
|
The doc test run currently in an older version and I don't see and easy way to solve that at the moment. I would suggest removing the doc checks for now and try to add them back in later. The main problem is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The TKET webiste will pick up the v1.31 from pypi once the release is put out and will build the docs.
After the 1.31 release is out we can re-enable the test of the docs build
Description
Please summarise the changes.
Related issues
Please mention any github issues addressed by this PR.
Checklist