Fix typo in name of CliffordPushThroughMeasures pass #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjdilkes
previously approved these changes
Aug 14, 2024
|
This pull request has been automatically marked as stale. |
isobelhooper
force-pushed
the
fix-typo-in-clifford-push-through-measures-pass
branch
from
f9957f4
to
7229b96
Compare
|
Hi @isobelhooper , when you make any change to the tket source you have to bump the tket patch version number in |
Noticed this typo while testing some code that used sequences of compiler passes.
isobelhooper
force-pushed
the
fix-typo-in-clifford-push-through-measures-pass
branch
from
7229b96
to
97d5f62
Compare
Thank you for this - have now made those changes in the commit as well! |
|
Ah, looks like homebrew have removed clang-format 18 so the formatting check is failing. I'll fix this in a separate PR... |
cqc-alec
requested changes
Sep 19, 2024
cqc-alec
approved these changes
Sep 19, 2024
cqc-alec
deleted the
fix-typo-in-clifford-push-through-measures-pass
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a typo in the JSON
namefield for the CliffordPushThroughMeasures pass. The pass is correctly named in the Python bindings, but the typo shows up in the output of.to_dict()for the generated compiler pass.This pass name isn't used in any tests (or output in the API docs, I think), so no test or docs changes are needed.
Checklist