Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in name of CliffordPushThroughMeasures pass #1532

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

isobelhooper
Copy link
Contributor

Description

This PR fixes a typo in the JSON name field for the CliffordPushThroughMeasures pass. The pass is correctly named in the Python bindings, but the typo shows up in the output of .to_dict() for the generated compiler pass.

This pass name isn't used in any tests (or output in the API docs, I think), so no test or docs changes are needed.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

sjdilkes
sjdilkes previously approved these changes Aug 14, 2024
Copy link

This pull request has been automatically marked as stale.

@github-actions github-actions bot added the stale label Sep 17, 2024
@isobelhooper isobelhooper force-pushed the fix-typo-in-clifford-push-through-measures-pass branch from f9957f4 to 7229b96 Compare September 17, 2024 10:39
@cqc-alec
Copy link
Collaborator

Hi @isobelhooper , when you make any change to the tket source you have to bump the tket patch version number in tket/conanfile.py and correspondingly the required version in pytket/conanfile.py. This is why the CI is failing.

Noticed this typo while testing some code that used sequences of compiler passes.
@isobelhooper
Copy link
Contributor Author

Hi @isobelhooper , when you make any change to the tket source you have to bump the tket patch version number in tket/conanfile.py and correspondingly the required version in pytket/conanfile.py. This is why the CI is failing.

Thank you for this - have now made those changes in the commit as well!

@cqc-alec
Copy link
Collaborator

Ah, looks like homebrew have removed clang-format 18 so the formatting check is failing. I'll fix this in a separate PR...

@github-actions github-actions bot removed the stale label Sep 18, 2024
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version needs bumping again.

pytket/conanfile.py Outdated Show resolved Hide resolved
tket/conanfile.py Outdated Show resolved Hide resolved
@cqc-alec cqc-alec merged commit 4794bbe into main Sep 19, 2024
32 checks passed
@cqc-alec cqc-alec deleted the fix-typo-in-clifford-push-through-measures-pass branch September 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants