Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add control_state argument to QControlBox #977

Merged
merged 16 commits into from
Aug 22, 2023

Conversation

yao-cqc
Copy link
Contributor

@yao-cqc yao-cqc commented Aug 18, 2023

No description provided.

@yao-cqc yao-cqc marked this pull request as ready for review August 21, 2023 08:46
@yao-cqc yao-cqc requested a review from cqc-alec August 21, 2023 09:25
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small comments.

tket/include/tket/Circuit/Boxes.hpp Show resolved Hide resolved
pytket/binders/circuit/boxes.cpp Outdated Show resolved Hide resolved
pytket/binders/circuit/boxes.cpp Outdated Show resolved Hide resolved
tket/test/src/Circuit/test_Boxes.cpp Show resolved Hide resolved
@yao-cqc yao-cqc requested a review from cqc-alec August 21, 2023 14:56
tket/include/tket/Circuit/Boxes.hpp Outdated Show resolved Hide resolved
tket/test/src/Circuit/test_Boxes.cpp Outdated Show resolved Hide resolved
yao-cqc and others added 2 commits August 21, 2023 16:29
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
@yao-cqc yao-cqc requested a review from cqc-alec August 21, 2023 16:19
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yao-cqc yao-cqc merged commit ea8b26e into develop Aug 22, 2023
33 checks passed
@yao-cqc yao-cqc deleted the feature/add-control-state-arg-to-QCtrlBox branch August 22, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants