chore: Move parallel evaluation code to CircuitChunks
#528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatoboiler
changed the title
CircuitChunksCircuitChunks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 83.96% 84.00% +0.03%
==========================================
Files 61 61
Lines 6685 6700 +15
Branches 6191 6206 +15
==========================================
+ Hits 5613 5628 +15
- Misses 790 791 +1
+ Partials 282 281 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
approved these changes
Aug 5, 2024
| @@ -440,7 +441,7 @@ where | |||
| logger.log_best(circ_cost.clone(), num_rewrites); | |||
|
|
|||
| let (joins, rx_work): (Vec<_>, Vec<_>) = chunks | |||
| .iter_mut() | |||
There was a problem hiding this comment.
I wasn't sure if this would improve the runtime, since the map block below is mostly just about creating new threads. But a quick test showed that this whole let (joins, rx_works) = ... block is now a lot faster!
On my laptop, trying multiple shots of
cargo run -p badger-optimiser --release -- -e test_files/eccs/nam_6_3.rwr -i
test_files/barenco_tof_10.json --split-circ -j N
while measuring the block time I get
Threads (N) |
Block time with iter_mut |
with par_iter_mut |
Comparison |
|---|---|---|---|
| 2 | 100ms | 57ms | 0.57 |
| 10 | 719ms | 471ms | 0.65 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #266