fix(internals): Drop default factories at exit #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up till now the static default factories provided by this crate would not be dropped on program exit, which would leak temporary directories into the user's file system. This commit fixes that bug by wrapping the factories in a mutex and an option and explicitly dropping them at program exit via use of `ctor`. Tests that tested this broken behavior have been removed, though we probably need some documentation to make users aware of the proper usage of static factories if they require more than one in their program.
johnchildren
commented
Nov 10, 2023
| .ok() | ||
| .flatten() | ||
| .map(|u| (u.uid, u.gid)) | ||
| .expect("no user `postgres` found is system") |
There was a problem hiding this comment.
Suggested change
| .expect("no user `postgres` found is system") | |
| .expect("no user `postgres` found in system") |
Probably also want to factor this out into a new function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till now the static default factories provided by this crate would not be dropped on program exit, which would leak temporary directories into the user's file system. This commit fixes that bug by wrapping the factories in a mutex and an option and explicitly dropping them at program exit via use of
ctor.Tests that tested this broken behavior have been removed, though we probably need some documentation to make users aware of the proper usage of static factories if they require more than one in their program.