Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove localhost url to prevent error: Can't combine fixed host and m… #8

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Remove localhost url to prevent error: Can't combine fixed host and m… #8

merged 1 commit into from
Jul 24, 2023

Conversation

mateuszkj
Copy link
Contributor

@mateuszkj mateuszkj commented Jul 7, 2023 •
edited
Loading

fixes #7

This MR removes hardcoded localhost from connection_string.

New connection_string will look like:

postgresql:///?host=/tmp/tmp-postgrust-socketKEpyHg&port=5432&dbname=demo&user=demo

New connection_string works with:

  • psql
  • tokio_postgres
  • sqlx
  • python sqlalchemy

@mateuszkj mateuszkj force-pushed the remove_localhost branch 2 times, most recently from 1dad65e to b023391 Compare July 7, 2023 09:18
@johnchildren johnchildren merged commit e622770 into CQCL:master Jul 24, 2023
@johnchildren
Copy link
Collaborator

Looks good, thank you!

@johnchildren
Copy link
Collaborator

Now released as v0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database url cannot be parsed by python sqlalchemy
2 participants
@mateuszkj @johnchildren