This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Fix escape key not working properly in city view #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape key should now close the city view and return to unit selection
chaorace
suggested changes
Oct 29, 2016
There was a problem hiding this comment.
This implementation isn't quite correct. When pressing the Esc key like this the city overview panel will remain open when everything else closes. The best way to address this would be removing the logic on lines 788 and 789, the interfacemode change is all you need to signal everything to close.
chaorace
approved these changes
Oct 29, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape key should now close the city view and return to unit selection