job的前端镜像支持传入自定义config+代码清理 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joshua <i@joshua.su>
Signed-off-by: joshua <i@joshua.su>
|
看来基建没修好，先merge吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
现在controller支持通过env
FRONT_CONFIG，给每一个创建的job绑定一个以FRONT_CONFIG内容以jobname-front的configmap,并会挂载到front container的/etc/frontConfig路径上。通过该功能，可以通过配置文件的方式配置caddy，提升拓展性。由于该功能紧急上线，job crd配置还未实现，马上会做的。
此外清理了下一些过时代码，并让传入的config能方便的初始化。