Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Implement settings for filament runout and PLR #193

Closed
Sebazzz opened this issue Feb 19, 2021 · 6 comments
Closed

[FR] Implement settings for filament runout and PLR #193

Sebazzz opened this issue Feb 19, 2021 · 6 comments
Labels
status:gfx-pending t:enhancement New feature or request
Milestone
Community Firmwar...

Comments

@Sebazzz
Copy link
Collaborator

Sebazzz commented Feb 19, 2021

Description

Allow turning filament runout sensor on/off and PLR.
@Sebazzz Sebazzz added this to the Community Firmware Release 6 milestone Feb 19, 2021
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Feb 19, 2021

I can't find an icon, so using this:

@Sebazzz Sebazzz added the t:enhancement New feature or request label Feb 19, 2021
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Feb 19, 2021

Suggested icon for PLR by a Discord user:

image

@Sebazzz Sebazzz mentioned this issue Feb 19, 2021
Closed
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Feb 19, 2021
@Sebazzz
Add first screen registration to DWIN
0f12418 
CR6Community/Marlin#193
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Feb 19, 2021
@Sebazzz
Add the toggle buttons
033f31b 
CR6Community/Marlin#193
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Feb 19, 2021
@Sebazzz
Add the misc nav button
bfbd14c 
CR6Community/Marlin#193
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Feb 19, 2021
@Sebazzz
When exiting screen: save
3e74d4c 
CR6Community/Marlin#193
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Feb 19, 2021
@Sebazzz
More DWIN
af523b4 
CR6Community/Marlin#193
Sebazzz added a commit that referenced this issue Feb 19, 2021
@Sebazzz
Implement toggles for misc settings #193
87da90b
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Feb 19, 2021

This is implemented too. @grobux I had no place to put a button for this screen so I've now put a hidden button on the title bar of the control screen.

@ztakis
Copy link

ztakis commented Feb 22, 2021

As a temporary (or not) solution, you might want to use the Creality logo at the home screen as a button that leads to the info screen and then change the info button in the Control screen to Misc. settings

Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Feb 23, 2021
@Sebazzz
Reshuffle control screen to make some room.
c503bfe 
Put firmware info and reset to factory on same line.
Set movement and misc settings on the same line as well.

CR6Community/Marlin#193
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Feb 23, 2021

@grobux I've decreased the size of the "reset to factory settings" button, and moved the info button to the left of it.
That makes room on the control screen to add a "misc settings" button. I'm actually pretty satisfied with this solution. Needs some final alignment checks of course, and proper fonts, but I'Il leave that to you 💯

@Sebazzz Sebazzz mentioned this issue Feb 24, 2021
Closed
@Sebazzz
Copy link
Collaborator Author

Sebazzz commented Mar 16, 2021

Thanks to this PR by @ztakis this has now been fully implemented: CR6Community/CR-6-touchscreen#40

@Sebazzz Sebazzz closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:gfx-pending t:enhancement New feature or request
Projects
None yet
Milestone
Community Firmware Release 6
Development

No branches or pull requests
2 participants
@Sebazzz @ztakis