Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Neopixel/RGB support on DGUS #231

Closed
Ranney1 opened this issue Mar 28, 2021 · 5 comments
Closed

[FR] Neopixel/RGB support on DGUS #231

Ranney1 opened this issue Mar 28, 2021 · 5 comments
Labels
area:dwin-interop Area - DWIN interop hw:SKR-CR6 BigTreeTech SKR CR-6 board t:enhancement New feature or request
Milestone
Community Firmwar...

Comments

@Ranney1
Copy link

Ranney1 commented Mar 28, 2021 •
edited
Loading

Sorry, had to ask...

Would be great to have neopixel support on the DGUS!

Options:

  • LED button can (also) turn Neopixel on/off
  • Special page on DGUS with color/brightness control
  • Errors (mismatch firmware) can control neopixel with red/yellow/blue state. (like events as implemented in Marlin).
  • Turn on/off 'follow system events'
  • Default brightness

Is this possible? A lot of work? Of course, if I'm the only one that is using neopixels than please remove this request!
@Sebazzz Sebazzz transferred this issue from CR6Community/CR-6-touchscreen Mar 28, 2021
@Sebazzz
Copy link
Collaborator

Sebazzz commented Mar 28, 2021

Moving to Marlin.

@Sebazzz Sebazzz added area:dwin-interop Area - DWIN interop hw:SKR-CR6 BigTreeTech SKR CR-6 board t:enhancement New feature or request labels Mar 28, 2021
@Sebazzz
Copy link
Collaborator

Sebazzz commented Mar 28, 2021

Sounds like fun, first need to buy another neopixel for my CR-6 with stock touch screen 😉

Sebazzz added a commit that referenced this issue Apr 11, 2021
@Sebazzz
Neopixel support in default config #231
c9f34ac
@Sebazzz
Copy link
Collaborator

Sebazzz commented Apr 11, 2021

I got my neopixel installed now. Any suggestion where to place this in the menu @Ranney1? Also taking #121 into account of course.

@Sebazzz Sebazzz changed the title Neopixel support on DGUS [FR] Neopixel support on DGUS Apr 11, 2021
@Sebazzz Sebazzz added this to the Community Firmware Release 7 milestone Apr 11, 2021
@Sebazzz Sebazzz changed the title [FR] Neopixel support on DGUS [FR] Neopixel/RGB support on DGUS Apr 11, 2021
Sebazzz added a commit that referenced this issue Apr 11, 2021
@Sebazzz
Add boilerplate for RBG screen #231
d72ff58
Sebazzz added a commit that referenced this issue Apr 11, 2021
@Sebazzz
Add nav button #231
2266973
Sebazzz added a commit that referenced this issue Apr 11, 2021
@Sebazzz
Add RGBWI controls #231
01cd630
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
Add base neopixel page without content
f3fbf3b 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
Add RGB nav button
f87a692 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
Add R slider (experimental)
6bc8feb 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
DWIN throwing away random controls again
b4cbc09 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
As always DWIN is a obscure pile of *** and I needed a different control
05f31c9 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
Add more sliders for RGBWI
a2dbf48 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
RGBWI slider icons
6a21d2b 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 11, 2021
@Sebazzz
Fix brightness VP
d4b3120 
CR6Community/Marlin#231
@Sebazzz
Copy link
Collaborator

Sebazzz commented Apr 11, 2021

Alright. This is implemented using something we didn't use before: slider controls.

Hopefully @ztakis / @grobux have time to make something decent of it, instead of my dabbling in Paint.NET 😄

Implementation notes:

  • Added page 81 RGB
  • Added icon 30, 31, 32, 33, 34 which represent the slider knob itself for R, G, B, W, and brightness respectively.
  • Added navigation in the misc settings (until we're doing something serious with [FR] Rework UI menu structure #121), and the extra tuning menu

Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
When lights are off, shows as zero #231
7701dbd
Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
Flash printer event LEDs when incorrect touch screen version #231
2063b7d
Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
Bump screen version to 61 #231
c4f9e0a
Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
Set default LEDs color at start #231
9091256
Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
Fix G/B color VPs #231
e7764ea
Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
Store the last set LED from the display in the settings #231
7b3237a
Sebazzz added a commit that referenced this issue Apr 12, 2021
@Sebazzz
Add full toggle show RGB settings only show when applicable #231
f1a9126
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 12, 2021
@Sebazzz
Update graphics for RGB
ef62bc2 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 12, 2021
@Sebazzz
Bump screen version to 61
22c6311 
CR6Community/Marlin#231
Sebazzz added a commit to CR6Community/CR-6-touchscreen that referenced this issue Apr 12, 2021
@Sebazzz
Add placeholder at 0x239E for navigation icon for RGB
c3c9be5 
CR6Community/Marlin#231
@Sebazzz
Copy link
Collaborator

Sebazzz commented Apr 12, 2021

@ztakis I made the RGB button into its own icon, so it only shows when applicable. You may want to update the PSD, but regeneration of the bitmaps is not needed 😉

This feature request has been fully implemented now.

@Sebazzz Sebazzz closed this as completed Apr 12, 2021
@Sebazzz Sebazzz mentioned this issue Apr 13, 2021
Closed
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Neopixel support in default config #231
81aa947 
(cherry picked from commit c9f34ac)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Add boilerplate for RBG screen #231
a98eb78 
(cherry picked from commit d72ff58)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Add nav button #231
afced4a 
(cherry picked from commit 2266973)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Add RGBWI controls #231
9b6bdae 
(cherry picked from commit 01cd630)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
When lights are off, shows as zero #231
9986ce0 
(cherry picked from commit 7701dbd)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Flash printer event LEDs when incorrect touch screen version #231
985a434 
(cherry picked from commit 2063b7d)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Bump screen version to 61 #231
df077f2 
(cherry picked from commit c4f9e0a)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Set default LEDs color at start #231
868429f 
(cherry picked from commit 9091256)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Add full toggle show RGB settings only show when applicable #231
5599a8c 
(cherry picked from commit f1a9126)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Store the last set LED from the display in the settings #231
8462e85 
(cherry picked from commit 7b3237a)
Sebazzz added a commit that referenced this issue Apr 25, 2021
@Sebazzz
Fix G/B color VPs #231
460e590 
(cherry picked from commit e7764ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dwin-interop Area - DWIN interop hw:SKR-CR6 BigTreeTech SKR CR-6 board t:enhancement New feature or request
Projects
None yet
Milestone
Community Firmware Release 6.1
Development

No branches or pull requests
2 participants
@Sebazzz @Ranney1