-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider): wekeo_ecmwf default dates #1288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd3a7b0
to
002d165
Compare
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 24d1aa2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)
Diff against develop
Results for commit: 24d1aa2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
split wekeo provider pull request has been merged - branch rebased on develop |
dalpasso
requested changes
Aug 23, 2024
dalpasso
approved these changes
Aug 26, 2024
sbrunato
requested changes
Sep 12, 2024
3e4ffc0
to
24d1aa2
Compare
sbrunato
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add default dates to the requests for the
wekeo_ecmwf
provider:missionStartDate
is used for start anddefault_end_date
/missionEndDate
/today is used for endwekeo_ecmwf
configTODO: clarify when
default_end_date
should be configured for a dataset-> Update: nobody seems to remember the purpose of
default_end_date
, so it could probably be removed