Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): usage of hydrological_year in provider wekeo_ecmwf #1313

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

dalpasso
Copy link
Collaborator

@dalpasso dalpasso commented Sep 5, 2024

  • Add mapping for parameter hydrological_year to provider wekeo_ecmwf and fix a typo in the orderLink
  • Pass down the _dc_qs for the PostJsonSearch when downloading the product
  • Manage leap years when calculating hydrological_year

Follow examples of queries and the generated _dc_qs. These tests can also be found in tests.units.test_search_plugins.TestSearchPluginPostJsonSearch.test_plugins_search_postjsonsearch_query_params_wekeo.

Using the datetime

curl --location 'http://localhost:5000/search?provider=wekeo_ecmwf' --header 'Content-Type: application/json' --data '{
    "collections": [
        "GRIDDED_GLACIERS_MASS_CHANGE"
    ],
    "limit": 10,
    "page": 1,
    "datetime": "1980-01-01T00:00:00Z/1981-12-31T23:59:59Z",
    "query": {
        "variable": {
            "eq": "glacier_mass_change"
        },
        "format": {
            "eq": "zip"
        },
        "version": {
            "eq": "wgms_fog_2022_09"
        }
    }
}'

Generated _dc_qs:

{
    "dataset_id": "EO:ECMWF:DAT:DERIVED_GRIDDED_GLACIER_MASS_CHANGE",
    "variable": "glacier_mass_change",
    "format": "zip",
    "product_version": "wgms_fog_2022_09",
    "hydrological_year": [
        "1980_81"
    ]
}

Using parameter hydrological_year (single value)

curl --location 'http://localhost:5000/search?provider=wekeo_ecmwf' \
--header 'Content-Type: application/json' \
--data '{
    "collections": [
        "GRIDDED_GLACIERS_MASS_CHANGE"
    ],
    "limit": 10,
    "page": 1,
    "query": {
        "variable": {
            "eq": "glacier_mass_change"
        },
        "format": {
            "eq": "zip"
        },
        "version": {
            "eq": "wgms_fog_2022_09"
        },
        "hydrological_year": {
            "eq": [
                "2020_21"
            ]
        }
    }
}'

Generated _dc_qs:

{
    "dataset_id": "EO:ECMWF:DAT:DERIVED_GRIDDED_GLACIER_MASS_CHANGE",
    "variable": "glacier_mass_change",
    "format": "zip",
    "product_version": "wgms_fog_2022_09",
    "hydrological_year": [
        "2020_21"
    ]
}

Using parameter hydrological_year (multiple values)

curl --location 'http://localhost:5000/search?provider=wekeo_ecmwf' \
--header 'Content-Type: application/json' \
--data '{
    "collections": [
        "GRIDDED_GLACIERS_MASS_CHANGE"
    ],
    "limit": 10,
    "page": 1,
    "query": {
        "variable": {
            "eq": "glacier_mass_change"
        },
        "format": {
            "eq": "zip"
        },
        "version": {
            "eq": "wgms_fog_2022_09"
        },
        "hydrological_year": {
            "eq": [
                "1990_91", "2020_21"
            ]
        }
    }
}'

Generated _dc_qs:

{
    "dataset_id": "EO:ECMWF:DAT:DERIVED_GRIDDED_GLACIER_MASS_CHANGE",
    "variable": "glacier_mass_change",
    "format": "zip",
    "product_version": "wgms_fog_2022_09",
    "hydrological_year": [
        "1990_91",
        "2020_21"
    ]
}

@dalpasso dalpasso requested a review from alambare September 5, 2024 09:25
@dalpasso dalpasso self-assigned this Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Test Results

    4 files  ±0      4 suites  ±0   6m 21s ⏱️ -2s
  565 tests +1    562 ✅ +1    3 💤 ±0  0 ❌ ±0 
2 260 runs  +4  2 158 ✅ +4  102 💤 ±0  0 ❌ ±0 

Results for commit 9a24db3. ± Comparison against base commit cecc9d8.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@alambare alambare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is normal that the format of the parameter is different than the other configured for provider wekeo ?

For instance with statistic:

    statistic:
        - '{{"statistic": {statistic}}}'
        - '$.null'

@dalpasso
Copy link
Collaborator Author

dalpasso commented Sep 5, 2024

It is normal that the format of the parameter is different than the other configured for provider wekeo ?

For instance with statistic:

    statistic:
        - '{{"statistic": {statistic}}}'
        - '$.null'

I used he same format of hydrological_model but it's indeed better to use the same format as other wekeo parameter. I have changed the format and tested that the resulting behavior is the same.

@dalpasso dalpasso force-pushed the add_mapping_hydrological_year_to_wekeo branch from 0621732 to 13d3a78 Compare September 5, 2024 10:43
@alambare alambare dismissed their stale review September 5, 2024 11:51

changes applied

@alambare alambare self-requested a review September 5, 2024 11:51
@dalpasso dalpasso marked this pull request as draft September 5, 2024 12:00
@dalpasso dalpasso force-pushed the add_mapping_hydrological_year_to_wekeo branch from 3031fc8 to 33dec24 Compare September 6, 2024 09:33
Copy link
Contributor

github-actions bot commented Sep 6, 2024

badge

Code Coverage (Ubuntu)

Filename                                     Stmts    Miss  Cover    Missing
-----------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
__init__.py                                      8       0  100.00%
cli.py                                         312      59  81.09%   655-714, 816-867, 871
config.py                                      367      27  92.64%   82-84, 93, 101, 105-107, 175, 186, 452-454, 514-517, 560-561, 570-571, 676, 739-744, 746
crunch.py                                        5       5  0.00%    20-24
api/__init__.py                                  0       0  100.00%
api/core.py                                    773      74  90.43%   636, 680-683, 721, 765, 799, 852-857, 883, 974, 1042, 1180, 1263-1275, 1311, 1313, 1341, 1345-1356, 1369-1375, 1458-1461, 1494-1514, 1566, 1583-1587, 1599-1602, 1624-1631, 1945, 1976-1982, 2233, 2237-2240, 2251-2253, 2285
api/search_result.py                            51       4  92.16%   73, 82, 89, 103
api/product/__init__.py                          6       0  100.00%
api/product/_assets.py                          48       5  89.58%   75, 147, 155, 158-162
api/product/_product.py                        187      20  89.30%   70-72, 237-238, 313, 342, 399, 413-416, 429, 453-456, 499-505
api/product/metadata_mapping.py                680      68  90.00%   130-132, 227, 259-260, 306-307, 317-329, 331, 342, 348-360, 405-406, 443, 464-467, 490, 498-499, 575-576, 600-601, 607-610, 625-626, 775, 821, 992-997, 1124, 1138-1158, 1178, 1183, 1312, 1326, 1397, 1449, 1489-1493, 1508
api/product/drivers/__init__.py                  6       0  100.00%
api/product/drivers/base.py                      6       1  83.33%   38
plugins/__init__.py                              0       0  100.00%
plugins/base.py                                 21       2  90.48%   48, 55
plugins/manager.py                             130      12  90.77%   104-109, 159, 197, 219, 223, 247, 281-282
plugins/apis/__init__.py                         0       0  100.00%
plugins/apis/base.py                             4       0  100.00%
plugins/apis/ecmwf.py                           91       8  91.21%   149-151, 198-199, 225-227
plugins/apis/usgs.py                           180      31  82.78%   132, 234, 268, 303-305, 310, 336-337, 342, 372-379, 390-395, 417-423, 425-431, 454
plugins/authentication/__init__.py               6       1  83.33%   31
plugins/authentication/aws_auth.py              19       0  100.00%
plugins/authentication/base.py                  17       2  88.24%   34, 47
plugins/authentication/generic.py               14       2  85.71%   40, 50
plugins/authentication/header.py                19       0  100.00%
plugins/authentication/keycloak.py              48       4  91.67%   134, 160-165
plugins/authentication/oauth.py                 13       7  46.15%   32-34, 38-41
plugins/authentication/openid_connect.py       187      17  90.91%   119, 133-158, 166, 320-323, 349
plugins/authentication/qsauth.py                34       1  97.06%   83
plugins/authentication/sas_auth.py              47       1  97.87%   76
plugins/authentication/token.py                 89      16  82.02%   79, 107, 109, 132-145, 201-205
plugins/authentication/token_exchange.py        36      20  44.44%   74-80, 92-122
plugins/crunch/__init__.py                       0       0  100.00%
plugins/crunch/base.py                          10       1  90.00%   40
plugins/crunch/filter_date.py                   59      14  76.27%   49-54, 66, 75, 84, 87, 99-101, 110-112, 119
plugins/crunch/filter_latest_intersect.py       47       8  82.98%   51-52, 68, 77-80, 82, 89-92
plugins/crunch/filter_latest_tpl_name.py        31       1  96.77%   83
plugins/crunch/filter_overlap.py                66      18  72.73%   28-30, 68-71, 78-81, 87, 95, 106-122
plugins/crunch/filter_property.py               30       7  76.67%   54-59, 62-63, 79-83
plugins/download/__init__.py                     0       0  100.00%
plugins/download/aws.py                        491     163  66.80%   266, 279, 346-349, 363-367, 409-411, 415, 447-448, 454-458, 487, 519, 523, 530, 560-568, 572, 604-612, 623-625, 659-733, 751-811, 822-827, 839-852, 877, 892-894, 897, 907-915, 923-936, 946-977, 984-996, 1034, 1060, 1105-1107, 1327
plugins/download/base.py                       253      51  79.84%   136, 164, 296-297, 314-320, 351-355, 361-362, 404, 407-421, 433, 437, 501-505, 535-536, 544-561, 568-576, 578-582, 625, 647, 669, 677
plugins/download/creodias_s3.py                 17       9  47.06%   44-58
plugins/download/http.py                       534     129  75.84%   195-207, 209-210, 242-245, 306-309, 311-312, 319-324, 342-357, 374-376, 388, 436, 443-449, 467, 481, 495, 503-505, 521-526, 537, 555, 597-601, 623, 663, 708, 722-728, 757-821, 839, 872-881, 903-904, 931-936, 942, 945, 961, 978-979, 1009-1010, 1017, 1078-1084, 1139-1140, 1146, 1156, 1192, 1228, 1246-1262, 1288-1290
plugins/download/s3rest.py                     116      24  79.31%   113, 149, 156, 191, 221-228, 231-233, 237, 248-254, 262-263, 266-270, 293, 314-317
plugins/search/__init__.py                      22       0  100.00%
plugins/search/base.py                         132      13  90.15%   102, 106, 117, 276, 296, 352-353, 373, 376-384
plugins/search/build_search_result.py          189      24  87.30%   96, 137-138, 144, 155, 289-292, 321, 356-373, 422, 451, 454, 464, 481, 509, 511
plugins/search/cop_marine.py                   197      47  76.14%   55, 63-65, 71-72, 88, 90, 93, 128-130, 142-143, 183-192, 196, 199, 203, 221, 249, 253, 268, 272, 276, 280, 284-288, 294-297, 300-314, 331, 354, 357, 363
plugins/search/creodias_s3.py                   55       3  94.55%   53, 71, 105
plugins/search/csw.py                          105      81  22.86%   58-59, 63-64, 72-120, 126-139, 147-179, 197-238
plugins/search/data_request_search.py          200      67  66.50%   90-93, 109, 120, 124-125, 136, 141, 146, 153, 166-169, 223-224, 228, 238-244, 249, 275-278, 286-297, 314, 316, 323-324, 326-327, 345-349, 382, 392, 403, 416, 422-437, 442
plugins/search/qssearch.py                     721      96  86.69%   390, 394-400, 408-409, 515-527, 571, 587, 597, 616-631, 668-671, 742-743, 791, 810, 817, 829, 886, 907, 910-911, 920-921, 930-931, 940-941, 968, 1039-1044, 1048-1057, 1091, 1113, 1173, 1222, 1286, 1289-1290, 1372-1376, 1438, 1441, 1447-1448, 1469, 1496-1508, 1515, 1547-1549, 1559-1565, 1595, 1618, 1633, 1655, 1738-1741, 1746-1749, 1776-1777, 1792
plugins/search/static_stac_search.py            72      10  86.11%   98-125, 141, 154
rest/__init__.py                                 4       2  50.00%   21-22
rest/cache.py                                   33       7  78.79%   35-37, 53-55, 59, 68
rest/config.py                                  26       0  100.00%
rest/constants.py                                7       0  100.00%
rest/core.py                                   234      26  88.89%   269, 355, 456, 672, 679-727
rest/server.py                                 283      53  81.27%   108, 131-133, 246-248, 304-305, 317-333, 425-430, 458, 623-630, 659, 703-704, 727, 798-800, 817-822, 851, 853, 857-858, 862-863
rest/stac.py                                   473     114  75.90%   318, 340, 392-395, 422-449, 480-482, 505, 537-538, 620-660, 682-698, 790-794, 801, 855-856, 917, 982-984, 1188, 1196-1208, 1219-1241, 1252-1297, 1456-1457
rest/types/__init__.py                           0       0  100.00%
rest/types/collections_search.py                13      13  0.00%    18-44
rest/types/eodag_search.py                     179       5  97.21%   232-236, 289, 292, 360
rest/types/queryables.py                        56       1  98.21%   164
rest/types/stac_search.py                      126       7  94.44%   129, 175, 190-192, 200, 204
rest/utils/__init__.py                          93      12  87.10%   108-109, 128-130, 182, 192-206
rest/utils/cql_evaluate.py                      48       5  89.58%   69, 76, 90, 97, 105
rest/utils/rfc3339.py                           23       3  86.96%   48, 60, 62
types/__init__.py                              114      14  87.72%   53, 70, 129-132, 199, 213-222, 232, 253, 266
types/bbox.py                                   43      19  55.81%   46-61, 72-74, 85-87, 99-101, 113-115, 123
types/download_args.py                           9       0  100.00%
types/queryables.py                             81       0  100.00%
types/search_args.py                            70      18  74.29%   60-64, 71-88, 103
types/whoosh.py                                 15       0  100.00%
utils/__init__.py                              500      37  92.60%   85, 90, 194-195, 204-231, 234, 248, 328-332, 406-410, 429-431, 510, 525, 561-562, 926-929, 937-938, 976-977, 1148
utils/constraints.py                           119      38  68.07%   62, 89-98, 139, 144, 148, 159, 182-184, 194, 208-224, 233-244
utils/exceptions.py                             35       1  97.14%   93
utils/import_system.py                          28      19  32.14%   64-78, 89-99
utils/logging.py                                28       1  96.43%   41
utils/notebook.py                               44      23  47.73%   25-29, 36-41, 58-62, 72-78, 83-87
utils/repr.py                                   30       8  73.33%   36, 38, 42, 76, 94-101
utils/requests.py                               55      11  80.00%   64, 88, 90, 92, 94, 96, 112, 120-122, 130
utils/rest.py                                   36       1  97.22%   55
utils/stac_reader.py                           111      45  59.46%   56-57, 63-85, 95-97, 101, 137, 153-156, 203-212, 222-252
TOTAL                                         9667    1636  83.08%

Diff against develop

Filename                           Stmts    Miss  Cover
-------------------------------  -------  ------  -------
api/core.py                           +1       0  +0.02%
api/product/metadata_mapping.py       +1       0  +0.01%
plugins/search/qssearch.py             0      -1  +0.14%
TOTAL                                 +2      -1  +0.02%

Results for commit: 9a24db3

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Sep 6, 2024

badge

Code Coverage (Windows)

Filename                                     Stmts    Miss  Cover    Missing
-----------------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
__init__.py                                      8       0  100.00%
cli.py                                         312      59  81.09%   655-714, 816-867, 871
config.py                                      367      28  92.37%   82-84, 93, 101, 105-107, 175, 186, 452-454, 514-517, 560-561, 570-571, 676, 707, 739-744, 746
crunch.py                                        5       5  0.00%    20-24
api/__init__.py                                  0       0  100.00%
api/core.py                                    773      74  90.43%   636, 680-683, 721, 765, 799, 852-857, 883, 974, 1042, 1180, 1263-1275, 1311, 1313, 1341, 1345-1356, 1369-1375, 1458-1461, 1494-1514, 1566, 1583-1587, 1599-1602, 1624-1631, 1945, 1976-1982, 2233, 2237-2240, 2251-2253, 2285
api/search_result.py                            51       4  92.16%   73, 82, 89, 103
api/product/__init__.py                          6       0  100.00%
api/product/_assets.py                          48       5  89.58%   75, 147, 155, 158-162
api/product/_product.py                        187      20  89.30%   70-72, 237-238, 313, 342, 399, 413-416, 429, 453-456, 499-505
api/product/metadata_mapping.py                680      68  90.00%   130-132, 227, 259-260, 306-307, 317-329, 331, 342, 348-360, 405-406, 443, 464-467, 490, 498-499, 575-576, 600-601, 607-610, 625-626, 775, 821, 992-997, 1124, 1138-1158, 1178, 1183, 1312, 1326, 1397, 1449, 1489-1493, 1508
api/product/drivers/__init__.py                  6       0  100.00%
api/product/drivers/base.py                      6       1  83.33%   38
plugins/__init__.py                              0       0  100.00%
plugins/base.py                                 21       3  85.71%   48, 55, 68
plugins/manager.py                             130      12  90.77%   104-109, 159, 197, 219, 223, 247, 281-282
plugins/apis/__init__.py                         0       0  100.00%
plugins/apis/base.py                             4       0  100.00%
plugins/apis/ecmwf.py                           91       8  91.21%   149-151, 198-199, 225-227
plugins/apis/usgs.py                           180      31  82.78%   132, 234, 268, 303-305, 310, 336-337, 342, 372-379, 390-395, 417-423, 425-431, 454
plugins/authentication/__init__.py               6       1  83.33%   31
plugins/authentication/aws_auth.py              19       0  100.00%
plugins/authentication/base.py                  17       2  88.24%   34, 47
plugins/authentication/generic.py               14       2  85.71%   40, 50
plugins/authentication/header.py                19       0  100.00%
plugins/authentication/keycloak.py              48       4  91.67%   134, 160-165
plugins/authentication/oauth.py                 13       7  46.15%   32-34, 38-41
plugins/authentication/openid_connect.py       187      17  90.91%   119, 133-158, 166, 320-323, 349
plugins/authentication/qsauth.py                34       1  97.06%   83
plugins/authentication/sas_auth.py              47       1  97.87%   76
plugins/authentication/token.py                 89      16  82.02%   79, 107, 109, 132-145, 201-205
plugins/authentication/token_exchange.py        36      20  44.44%   74-80, 92-122
plugins/crunch/__init__.py                       0       0  100.00%
plugins/crunch/base.py                          10       1  90.00%   40
plugins/crunch/filter_date.py                   59      14  76.27%   49-54, 66, 75, 84, 87, 99-101, 110-112, 119
plugins/crunch/filter_latest_intersect.py       47      33  29.79%   48-53, 66-111
plugins/crunch/filter_latest_tpl_name.py        31       1  96.77%   83
plugins/crunch/filter_overlap.py                66      18  72.73%   28-30, 68-71, 78-81, 87, 95, 106-122
plugins/crunch/filter_property.py               30       7  76.67%   54-59, 62-63, 79-83
plugins/download/__init__.py                     0       0  100.00%
plugins/download/aws.py                        491     163  66.80%   266, 279, 346-349, 363-367, 409-411, 415, 447-448, 454-458, 487, 519, 523, 530, 560-568, 572, 604-612, 623-625, 659-733, 751-811, 822-827, 839-852, 877, 892-894, 897, 907-915, 923-936, 946-977, 984-996, 1034, 1060, 1105-1107, 1327
plugins/download/base.py                       253      53  79.05%   136, 164, 231-233, 296-297, 314-320, 351-355, 361-362, 404, 407-421, 433, 437, 501-505, 535-536, 544-561, 568-576, 578-582, 625, 647, 669, 677
plugins/download/creodias_s3.py                 17       9  47.06%   44-58
plugins/download/http.py                       534     130  75.66%   195-207, 209-210, 242-245, 306-309, 311-312, 319-324, 342-357, 374-376, 388, 436, 443-449, 467, 481, 495, 503-505, 521-526, 537, 555, 597-601, 623, 663, 708, 722-728, 757-821, 839, 872-881, 903-904, 931-936, 942, 945, 961, 978-979, 992, 1009-1010, 1017, 1078-1084, 1139-1140, 1146, 1156, 1192, 1228, 1246-1262, 1288-1290
plugins/download/s3rest.py                     116      24  79.31%   113, 149, 156, 191, 221-228, 231-233, 237, 248-254, 262-263, 266-270, 293, 314-317
plugins/search/__init__.py                      22       0  100.00%
plugins/search/base.py                         132      14  89.39%   102, 106, 117, 276, 296, 352-353, 373, 376-384, 386
plugins/search/build_search_result.py          189      31  83.60%   96, 137-138, 144, 155, 289-292, 321, 356-373, 422, 451, 454, 464, 481, 501-516
plugins/search/cop_marine.py                   197      47  76.14%   55, 63-65, 71-72, 88, 90, 93, 128-130, 142-143, 183-192, 196, 199, 203, 221, 249, 253, 268, 272, 276, 280, 284-288, 294-297, 300-314, 331, 354, 357, 363
plugins/search/creodias_s3.py                   55       3  94.55%   53, 71, 105
plugins/search/csw.py                          105      81  22.86%   58-59, 63-64, 72-120, 126-139, 147-179, 197-238
plugins/search/data_request_search.py          200      67  66.50%   90-93, 109, 120, 124-125, 136, 141, 146, 153, 166-169, 223-224, 228, 238-244, 249, 275-278, 286-297, 314, 316, 323-324, 326-327, 345-349, 382, 392, 403, 416, 422-437, 442
plugins/search/qssearch.py                     721     125  82.66%   390, 394-400, 408-409, 515-527, 571, 574, 587, 597, 616-631, 668-671, 742-743, 791, 810, 817, 829, 886, 907, 910-911, 920-921, 930-931, 940-941, 968, 1039-1044, 1048-1057, 1091, 1113, 1173, 1222, 1286, 1289-1290, 1372-1376, 1438, 1441, 1447-1448, 1469, 1496-1508, 1515, 1547-1549, 1559-1565, 1595, 1618, 1633, 1655, 1721-1821
plugins/search/static_stac_search.py            72      10  86.11%   98-125, 141, 154
rest/__init__.py                                 4       2  50.00%   21-22
rest/cache.py                                   33      22  33.33%   35-37, 44-70
rest/config.py                                  26       1  96.15%   36
rest/constants.py                                7       0  100.00%
rest/core.py                                   234     129  44.87%   162, 164, 166, 171-172, 193-202, 213-219, 260-314, 327-365, 396-430, 445-461, 479-490, 504-535, 552, 594-633, 672, 679-727
rest/server.py                                 283     283  0.00%    18-874
rest/stac.py                                   473     175  63.00%   252, 318, 340, 392-395, 422-449, 480-482, 505, 537-538, 620-660, 682-698, 725, 790-794, 801, 855-856, 862, 915, 917, 973, 982-984, 1000-1002, 1009-1011, 1023-1025, 1037-1054, 1062-1083, 1091-1113, 1120-1137, 1156-1179, 1188, 1196-1208, 1219-1241, 1252-1297, 1341-1374, 1450-1476
rest/types/__init__.py                           0       0  100.00%
rest/types/collections_search.py                13      13  0.00%    18-44
rest/types/eodag_search.py                     179      14  92.18%   232-236, 269-271, 289, 292, 298, 302, 360, 372-375
rest/types/queryables.py                        56      13  76.79%   51-52, 59-60, 67-68, 94-99, 108-109, 164
rest/types/stac_search.py                      126      11  91.27%   127-129, 175, 190-192, 200, 204, 252, 255
rest/utils/__init__.py                          93      30  67.74%   79-85, 105, 108-109, 128-130, 143, 150, 175-183, 190-211
rest/utils/cql_evaluate.py                      48       5  89.58%   69, 76, 90, 97, 105
rest/utils/rfc3339.py                           23       5  78.26%   43-44, 48, 60, 62
types/__init__.py                              114      39  65.79%   53, 66-70, 81-93, 120-122, 129-132, 172, 199, 209-225, 230, 232, 253, 258, 266, 276
types/bbox.py                                   43      19  55.81%   46-61, 72-74, 85-87, 99-101, 113-115, 123
types/download_args.py                           9       0  100.00%
types/queryables.py                             81       0  100.00%
types/search_args.py                            70      18  74.29%   60-64, 71-88, 103
types/whoosh.py                                 15       0  100.00%
utils/__init__.py                              500      37  92.60%   85, 90, 194-195, 204-231, 234, 248, 328-332, 406-410, 429-431, 510, 525, 561-562, 926-929, 937-938, 976-977, 1148
utils/constraints.py                           119      38  68.07%   62, 89-98, 139, 144, 148, 159, 182-184, 194, 208-224, 233-244
utils/exceptions.py                             35       1  97.14%   93
utils/import_system.py                          28      19  32.14%   64-78, 89-99
utils/logging.py                                28       1  96.43%   41
utils/notebook.py                               44      23  47.73%   25-29, 36-41, 58-62, 72-78, 83-87
utils/repr.py                                   30       8  73.33%   36, 38, 42, 76, 94-101
utils/requests.py                               55      11  80.00%   64, 88, 90, 92, 94, 96, 112, 120-122, 130
utils/rest.py                                   36       1  97.22%   55
utils/stac_reader.py                           111      45  59.46%   56-57, 63-85, 95-97, 101, 137, 153-156, 203-212, 222-252
TOTAL                                         9667    2183  77.42%

Diff against develop

Filename                           Stmts    Miss  Cover
-------------------------------  -------  ------  -------
api/core.py                           +1       0  +0.02%
api/product/metadata_mapping.py       +1       0  +0.01%
plugins/search/qssearch.py             0      -1  +0.14%
TOTAL                                 +2      -1  +0.02%

Results for commit: 9a24db3

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@dalpasso dalpasso changed the title Add mapping for parameter hydrological_year to provider wekeo_ecmwf Fix usage of parameter hydrological_year in provider wekeo_ecmwf Sep 6, 2024
@dalpasso dalpasso marked this pull request as ready for review September 6, 2024 11:48
@dalpasso dalpasso force-pushed the add_mapping_hydrological_year_to_wekeo branch from 33dec24 to 12c371f Compare September 6, 2024 11:52
@dalpasso dalpasso marked this pull request as draft September 6, 2024 12:03
@dalpasso dalpasso marked this pull request as ready for review September 9, 2024 08:00
@alambare alambare requested review from jlahovnik and removed request for alambare September 11, 2024 12:30
@alambare alambare added the dedl DEDL related label Sep 12, 2024
@sbrunato sbrunato marked this pull request as draft September 13, 2024 07:48
@dalpasso dalpasso force-pushed the add_mapping_hydrological_year_to_wekeo branch from 466edbb to 9a24db3 Compare September 13, 2024 08:32
@sbrunato sbrunato marked this pull request as ready for review September 13, 2024 08:41
@sbrunato sbrunato changed the title Fix usage of parameter hydrological_year in provider wekeo_ecmwf fix(providers): usage of hydrological_year in provider wekeo_ecmwf Sep 13, 2024
@sbrunato sbrunato merged commit 6088572 into develop Sep 13, 2024
10 checks passed
@sbrunato sbrunato deleted the add_mapping_hydrological_year_to_wekeo branch September 13, 2024 08:43
@sbrunato sbrunato added this to the 3.0.0.dev milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dedl DEDL related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants