Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): handle DownloadError and RequestError in server mode #806

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

sbrunato
Copy link
Collaborator

@sbrunato sbrunato commented Sep 1, 2023

Handle DownloadError and RequestError in server mode and return them as 500 errors including exception message

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Test Results

       4 files  ±0         4 suites  ±0   5m 14s ⏱️ -1s
   408 tests ±0     406 ✔️ ±0    2 💤 ±0  0 ±0 
1 632 runs  ±0  1 564 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit c001d71. ± Comparison against base commit 2af2d90.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against c001d71

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Code Coverage (Windows)

File Coverage
All files 75%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against c001d71

@sbrunato sbrunato merged commit 3e9ec56 into develop Sep 1, 2023
@sbrunato sbrunato deleted the server_err_handling branch September 1, 2023 11:00
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant