Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(creodias): use zipper URL to avoid unecessary redirect #819

Merged
merged 1 commit into from
Sep 14, 2023
Merged

perf(creodias): use zipper URL to avoid unecessary redirect #819

merged 1 commit into from
Sep 14, 2023

Conversation

alambare
Copy link
Collaborator

@alambare alambare commented Sep 11, 2023 •
edited by sbrunato
Loading

datahub URL redirects to zipper url.
Use CREODIAS zipper URL instead of datahub for downloadLink to avoid the redirect.

@github-actions
Copy link
Contributor

Test Results

       4 files  ±0         4 suites  ±0   6m 43s ⏱️ + 1m 20s
   413 tests ±0     411 ✔️ ±0    2 💤 ±0  0 ❌ ±0 
1 652 runs  ±0  1 584 ✔️ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit f97fc8b. ± Comparison against base commit e100b96.

@github-actions
Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against f97fc8b

@github-actions
Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 75% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against f97fc8b

@alambare alambare requested a review from sbrunato September 11, 2023 07:51
@sbrunato sbrunato merged commit 812bc56 into develop Sep 14, 2023
@sbrunato sbrunato deleted the creodias-update-downloadlink-url branch September 14, 2023 13:02
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato Awaiting requested review from sbrunato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alambare @sbrunato