Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): properly display next page object #895

Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix(server): properly display next page object #895

merged 4 commits into from
Dec 6, 2023

Conversation

bjgiraudon
Copy link
Collaborator

Description

This PR fixes the next link display in search requests (both GET and POST).
It provides a URL to the next page and the json body in the case of a POST request.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Test Results

       4 files  ±  0         4 suites  ±0   3m 25s ⏱️ -1s
   436 tests +  3     433 ✔️ +  3    3 💤 ±0  0 ❌ ±0 
1 744 runs  +12  1 668 ✔️ +12  76 💤 ±0  0 ❌ ±0 

Results for commit cec91fe. ± Comparison against base commit b6dd367.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against cec91fe

@bjgiraudon bjgiraudon force-pushed the 886-fix-response-links-next branch from e5081b6 to 1f4f776 Compare October 20, 2023 13:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Code Coverage (Windows)

File Coverage
All files 76% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against cec91fe

@bjgiraudon bjgiraudon requested a review from alambare October 20, 2023 14:20
@bjgiraudon bjgiraudon linked an issue Oct 26, 2023 that may be closed by this pull request
query parameters missing in next link #886
Closed
@bjgiraudon bjgiraudon added the bug Something isn't working label Oct 26, 2023
@alambare alambare force-pushed the 886-fix-response-links-next branch from 1f4f776 to 79fedc8 Compare November 28, 2023 07:40
sbrunato
sbrunato requested changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests for GET & POST methods

eodag/rest/utils.py Outdated Show resolved Hide resolved
eodag/rest/utils.py Outdated Show resolved Hide resolved
@sbrunato sbrunato marked this pull request as draft December 5, 2023 15:51
@alambare alambare force-pushed the 886-fix-response-links-next branch from 79fedc8 to 54d348b Compare December 6, 2023 14:12
@alambare alambare requested a review from sbrunato December 6, 2023 15:03
@alambare alambare marked this pull request as ready for review December 6, 2023 15:03
@sbrunato sbrunato changed the title fix(search): properly display next page object fix(server): properly display next page object Dec 6, 2023
@sbrunato sbrunato merged commit 17244d7 into develop Dec 6, 2023
11 checks passed
@sbrunato sbrunato deleted the 886-fix-response-links-next branch December 6, 2023 18:04
alambare added a commit that referenced this pull request Dec 12, 2023
@bjgiraudon @alambare
fix(server): properly display next page object (#895)
cc0d53f 
Co-authored-by: Aubin Lambaré <aubin.lambare@csgroup.eu>
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alambare alambare alambare approved these changes

@sbrunato sbrunato sbrunato approved these changes

Assignees

@bjgiraudon bjgiraudon

Labels
bug Something isn't working
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

query parameters missing in next link
3 participants
@bjgiraudon @sbrunato @alambare