-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new core method get_queryables #917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Code Coverage (Ubuntu)
Minimum allowed coverage is Generated by 🐒 cobertura-action against a287c9f |
Code Coverage (Windows)
Minimum allowed coverage is Generated by 🐒 cobertura-action against a287c9f |
sbrunato
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- if given provider is not found, please raise
UnsupportedProvider()
- if given product_type is not found, please raise
UnsupportedProductType()
- if product type is given, but no provider, only return preferred provider queryables instead of the union of all possibles
Changed the implementation:
|
1af5513
to
90dfc11
Compare
Co-authored-by: Sylvain Brunato <61419125+sbrunato@users.noreply.github.com>
- If product_type is given, but no provider, only return preferred provider queryables. - raise exception if the given provider or product_type don't exist
- all providers have a default list of queryables parameters - if a product type is given, but no provider, then return the intersection of the queryables of all the providers supporting it
e684b24
to
b471cf5
Compare
sbrunato
approved these changes
Dec 6, 2023
alambare
added a commit
that referenced
this pull request
Dec 12, 2023
Co-authored-by: LAMBARE Aubin <aubin.lambare@csgroup.eu> Co-authored-by: Sylvain Brunato <sylvain.brunato@c-s.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new core method
def get_queryables(provider=None, product_type=None) -> List[str]
:provider
and noproduct_type
are passed, then returns default search method queryable parameters:["productType", "start", "end", "geom", "locations", "id"]
provider
is passed (but noproduct_type
), then returns its queryable parameters from provider's configproduct_type
is passed (but noprovider
), then return the intersection of the queryables of all the providers supporting itproduct_type
and aprovider
are passed, then returns the queryable parameters from provider's config and the queryable parameters for that product typeThe following exceptions are raised:
UnsupportedProvider()
if the givenprovider
is not foundUnsupportedProductType()
if the givenproduct_type
is not found