Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing stac properties + fix typo #947

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: add missing stac properties + fix typo #947

merged 1 commit into from
Dec 6, 2023

Conversation

alambare
Copy link
Collaborator

@alambare alambare commented Dec 1, 2023 •
edited by sbrunato
Loading

  • add STAC property eo:snow_cover
  • use STAC extension property sat:absolute_orbit instead of oseo:orbitNumber
  • fix typo: intruments -> instruments
  • consider elements part of list in STAC oseo metadata mapping (oseo:instrument is not added because STAC common metadata instruments exists).

@alambare alambare self-assigned this Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

Test Results

       4 files  ±0         4 suites  ±0   3m 27s ⏱️ +5s
   433 tests ±0     430 ✔️ ±0    3 💤 ±0  0 ❌ ±0 
1 732 runs  ±0  1 656 ✔️ ±0  76 💤 ±0  0 ❌ ±0 

Results for commit 56f8a24. ± Comparison against base commit 1631c88.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 56f8a24

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

Code Coverage (Windows)

File Coverage
All files 76% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 56f8a24

@alambare alambare force-pushed the fix/stac-item-properties branch from 5d8fc57 to 56f8a24 Compare December 1, 2023 18:15
@alambare alambare requested a review from sbrunato December 1, 2023 18:21
@sbrunato sbrunato merged commit 6823a97 into develop Dec 6, 2023
11 checks passed
@sbrunato sbrunato deleted the fix/stac-item-properties branch December 6, 2023 08:41
alambare added a commit that referenced this pull request Dec 12, 2023
@alambare
fix: add missing stac properties + fix typo (#947)
f4cb80d
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato sbrunato approved these changes

Assignees

@alambare alambare

Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alambare @sbrunato