Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[server]: add cql2 support #966

Merged
merged 44 commits into from
Feb 29, 2024
Merged

feat[server]: add cql2 support #966

merged 44 commits into from
Feb 29, 2024

Conversation

alambare
Copy link
Collaborator

@alambare alambare commented Dec 19, 2023 •
edited
Loading

EODAG server updates:

  • feat: cql2-json support for POST search
  • feat: cql2-text and cql2-json for GET search
  • feat: validation on STAC search with pydantic model
  • feat: model for STAC to EODAG search conversion
  • refactor: simplify STAC server implementation
  • fix: add item thumbnail only if exists in product
  • feat: add asset type for thumbnail

EODAG updates:

  • feat: add asset type for creodias s3

@alambare alambare self-assigned this Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Test Results

    4 files  ±  0      4 suites  ±0   4m 58s ⏱️ +17s
  501 tests + 29    498 ✅ + 29   3 💤 ±0  0 ❌ ±0 
2 004 runs  +116  1 920 ✅ +114  84 💤 +2  0 ❌ ±0 

Results for commit 47421c1. ± Comparison against base commit d4d6bdf.

This pull request removes 31 and adds 60 tests. Note that renamed tests count towards both. 
tests.units.test_http_server.RequestTestCase ‑ test_download_item_from_catalog
tests.units.test_http_server.RequestTestCase ‑ test_download_item_from_collection_api_plugin
tests.units.test_stac_utils.TestStacUtils ‑ test_detailled_collections_list
tests.units.test_stac_utils.TestStacUtils ‑ test_filter_products
tests.units.test_stac_utils.TestStacUtils ‑ test_filter_products_filter_misuse_raise_error
tests.units.test_stac_utils.TestStacUtils ‑ test_filter_products_missing_additional_parameters_raise_error
tests.units.test_stac_utils.TestStacUtils ‑ test_filter_products_unknown_cruncher_raise_error
tests.units.test_stac_utils.TestStacUtils ‑ test_format_product_types
tests.units.test_stac_utils.TestStacUtils ‑ test_get_arguments_query_paths
tests.units.test_stac_utils.TestStacUtils ‑ test_get_criterias_from_metadata_mapping
…

tests.units.test_http_server.RequestTestCase ‑ test_cql_post_search
tests.units.test_http_server.RequestTestCase ‑ test_download_item_from_catalog_stream
tests.units.test_http_server.RequestTestCase ‑ test_download_item_from_collection_no_stream
tests.units.test_stac_core.TestStacCore ‑ test_crunch_products
tests.units.test_stac_core.TestStacCore ‑ test_crunch_products_filter_misuse_raise_error
tests.units.test_stac_core.TestStacCore ‑ test_crunch_products_missing_additional_parameters_raise_error
tests.units.test_stac_core.TestStacCore ‑ test_crunch_products_unknown_cruncher_raise_error
tests.units.test_stac_core.TestStacCore ‑ test_detailled_collections_list
tests.units.test_stac_core.TestStacCore ‑ test_format_product_types
tests.units.test_stac_core.TestStacCore ‑ test_get_geometry
…

♻️ This comment has been updated with latest results.

@alambare alambare added server Server-mode related dedl DEDL related labels Dec 19, 2023
@alambare alambare force-pushed the feat/rework-stac branch 2 times, most recently from 81e4a38 to 139dfbc Compare December 19, 2023 16:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 6d26082

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Code Coverage (Windows)

File Coverage
All files 76% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 6d26082

@alambare alambare requested a review from sbrunato December 19, 2023 16:06
@alambare alambare force-pushed the feat/rework-stac branch 5 times, most recently from ce9d9fc to f64d5c6 Compare January 11, 2024 14:57
@alambare alambare force-pushed the feat/rework-stac branch 5 times, most recently from 0f699cc to d2bb36b Compare January 19, 2024 11:14
@alambare alambare changed the title feat[server]: add cql2-json support feat[server]: add cql2 support Jan 19, 2024
@alambare alambare force-pushed the feat/rework-stac branch 9 times, most recently from f8c7be1 to 26415b4 Compare January 26, 2024 08:41
sbrunato
sbrunato requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment •
edited by alambare
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

  • Update NOTICE with new dependencies

@sbrunato sbrunato marked this pull request as draft February 23, 2024 17:22
sbrunato
sbrunato requested changes Feb 23, 2024
View reviewed changes
@alambare alambare requested a review from sbrunato February 27, 2024 14:38
@alambare alambare marked this pull request as ready for review February 27, 2024 14:38
@sbrunato sbrunato marked this pull request as draft February 28, 2024 08:32
@alambare alambare marked this pull request as ready for review February 28, 2024 14:27
@sbrunato sbrunato merged commit 5901a6e into develop Feb 29, 2024
10 checks passed
@sbrunato sbrunato deleted the feat/rework-stac branch February 29, 2024 13:41
This was referenced Mar 4, 2024
Merged
Closed
@sbrunato sbrunato added this to the 3.0.0b1 milestone Jul 12, 2024
@sbrunato sbrunato mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato sbrunato approved these changes

Assignees

@alambare alambare

Labels
dedl DEDL related server Server-mode related
Projects
None yet
Milestone
3.0.0b1
Development

Successfully merging this pull request may close these issues.
2 participants
@alambare @sbrunato