-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use constraints for queryables #981
Conversation
jlahovnik
commented
Jan 11, 2024
- queryables are created based on constraints if constraints_file_url is given for a provider (currently only implemented for cop_ads/cop_cds, wekeo can be done as soon as it is updated to the new endpoint)
- possible values are added to the queryables (if available)
- queryable parameters can be added to the request, to get only values matching the given condition for other queryables
Code Coverage (Ubuntu)
Minimum allowed coverage is Generated by 🐒 cobertura-action against 88a3f2e |
Code Coverage (Windows)
Minimum allowed coverage is Generated by 🐒 cobertura-action against 88a3f2e |
567a162
to
0ea7cbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please:
- add a
value
attribute (fromproviders.yml
default or given value) for returned queryables- this value should also be returned by lib methods, instead of actual default value
- pre-filter queryables available values using default values
- In
datetime
description, tell to refer toyear
,month
,day
contraints, if available - return
ids
and notid
- return
collections
and notcollection
- return
geometry
and notbbox
- add schema for
geometry
all change requests should be resolved |
all change requests implemented |
ffa2c22
to
231bc43
Compare
branch rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- when a parameter has a default value pre-configured, other available values are not listed, for example, on
http://127.0.0.1:5000/collections/ERA5_SL/queryables?provider=cop_cds
forapi_product_type
, we onlyreanalysis
is listed, other values are missing - also we may be able to override defaults with given additional filters (giving an empty value, or
None
in library mode), in order to be able to list all combinations
Defaults can now be removed by setting them to empty in the query params. In that case all the values of the parameter are no and no filtering by this parameter is applied. |
56c8be8
to
f1e82c4
Compare
f1e82c4
to
11b12d0
Compare