Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

923 new provider for creodias s3 #986

Merged
merged 28 commits into from
Jan 18, 2024
Merged

923 new provider for creodias s3 #986

merged 28 commits into from
Jan 18, 2024

Conversation

jlahovnik
Copy link
Collaborator

  • provider creodias s3 added
  • new plugins for search (CreodiasS3Search) and download (CreodiasS3Download) created

@jlahovnik jlahovnik self-assigned this Jan 12, 2024
@jlahovnik jlahovnik linked an issue Jan 12, 2024 that may be closed by this pull request
new provider for creodias S3 #923
Closed
@jlahovnik jlahovnik force-pushed the 923-new-provider-for-creodias-s3 branch from 089d6d7 to 85a8b95 Compare January 12, 2024 14:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Test Results

    4 files  ± 0      4 suites  ±0   4m 17s ⏱️ +9s
  452 tests + 3    449 ✅ + 3   3 💤 ±0  0 ❌ ±0 
1 808 runs  +12  1 730 ✅ +12  78 💤 ±0  0 ❌ ±0 

Results for commit b1e8a20. ± Comparison against base commit 819247c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against b1e8a20

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Code Coverage (Windows)

File Coverage
All files 76% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against b1e8a20

@sbrunato sbrunato force-pushed the 923-new-provider-for-creodias-s3 branch 2 times, most recently from 827675d to 21eacc9 Compare January 17, 2024 08:30
sbrunato
sbrunato requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment •
edited by jlahovnik
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

@sbrunato sbrunato marked this pull request as draft January 17, 2024 08:34
@jlahovnik jlahovnik marked this pull request as ready for review January 17, 2024 12:41
jlahovnik and others added 19 commits January 17, 2024 14:35
@jlahovnik
feat: add creodias s3 provider
ea2db89
@jlahovnik
feat: adaptations for creodias s3
f35c03e
@jlahovnik
test: add creodias_s3 provider in tests
07eee5d
@jlahovnik
test: creodias s3 search plugin
de6105c
@jlahovnik
test: adapt failing test
b061249
@jlahovnik
refactor: use auth dict variables to authenticate in creodias s3 down…
87a2624 
…load
@jlahovnik
refactor: handle s3 client exception in creodias s3 search plugin
f96ec84
@sbrunato @jlahovnik
fix: use a single s3 client to list all assets
283f0d4
@sbrunato @jlahovnik
refactor: error handling and copyright
24b0965
@sbrunato @jlahovnik
style: type hints fixes
71d0981
@jlahovnik
test: creodias s3 plugins
660966a
@jlahovnik
feat: add creodias s3 provider
063169d
@jlahovnik
feat: adaptations for creodias s3
c52f095
@jlahovnik
test: creodias s3 search plugin
26330ab
@jlahovnik
refactor: use auth dict variables to authenticate in creodias s3 down…
c85899f 
…load
@jlahovnik
refactor: handle s3 client exception in creodias s3 search plugin
d3032be
@sbrunato @jlahovnik
refactor: error handling and copyright
b548fa2
@jlahovnik
test: remove unnecessary line
a9a700f
@jlahovnik
docs: add doc for creodias s3 provider
550c0be
sbrunato
sbrunato requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@sbrunato sbrunato left a comment •
edited by jlahovnik
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrunato sbrunato marked this pull request as draft January 17, 2024 13:56
@jlahovnik jlahovnik force-pushed the 923-new-provider-for-creodias-s3 branch from 5932b26 to 550c0be Compare January 17, 2024 14:00
@jlahovnik jlahovnik marked this pull request as ready for review January 17, 2024 14:51
@sbrunato sbrunato force-pushed the 923-new-provider-for-creodias-s3 branch from 97cdf7a to b1e8a20 Compare January 18, 2024 13:52
@sbrunato sbrunato merged commit dda681a into develop Jan 18, 2024
12 checks passed
@sbrunato sbrunato deleted the 923-new-provider-for-creodias-s3 branch January 18, 2024 14:01
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato sbrunato approved these changes

Assignees

@jlahovnik jlahovnik

Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

new provider for creodias S3
2 participants
@jlahovnik @sbrunato