Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!!Breaking changes multiple features!!! #169

Merged
merged 5 commits into from
Nov 8, 2018
Merged

!!!Breaking changes multiple features!!! #169

merged 5 commits into from
Nov 8, 2018

Conversation

j-lum
Copy link

@j-lum j-lum commented Nov 6, 2018

  • History for transformations now working.
  • Layer panel now working.
  • 'raw' command now added. Use with caution!

Jeffry Lum added 4 commits November 6, 2018 14:02
!!!Breaking changes multiple features!!!
9dbf2e7 
- History for transformations now working.
- Layer panel now working.
- 'raw' command now added. Use with caution!
Fixed some tests and removed extra exceptions.
a4d04e9
Added documentation for trivial functions.
3a3756b
Removed old tests for HistoryPanel
8dbb824
@coveralls
Copy link

coveralls commented Nov 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 413

  • 72 of 127 (56.69%) changed or added relevant lines in 21 files are covered.
  • 30 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-2.4%) to 75.428%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/PiconsoParser.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/layer/LayerAddCommand.java 0 2 0.0%
src/main/java/seedu/address/logic/parser/RawCommandParser.java 0 2 0.0%
src/main/java/seedu/address/model/ModelManager.java 24 26 92.31%
src/main/java/seedu/address/logic/commands/ConvertCommand.java 0 3 0.0%
src/main/java/seedu/address/ui/HistoryListPanel.java 0 4 0.0%
src/main/java/seedu/address/commons/util/ImageMagickUtil.java 0 10 0.0%
src/main/java/seedu/address/logic/commands/RawCommand.java 0 15 0.0%
src/main/java/seedu/address/ui/LayerListPanel.java 9 25 36.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/model/ModelManager.java 1 78.4%
src/main/java/seedu/address/logic/commands/ConvertCommand.java 2 44.44%
src/main/java/seedu/address/commons/events/ui/ClearHistoryEvent.java 3 0.0%
src/main/java/seedu/address/commons/events/ui/AllTransformationEvent.java 4 0.0%
src/main/java/seedu/address/commons/events/ui/TransformationEvent.java 9 0.0%
src/main/java/seedu/address/ui/HistoryListPanel.java 11 37.5%
Totals Coverage Status
Change from base Build 412: -2.4%
Covered Lines: 1851
Relevant Lines: 2454
💛 - Coveralls

@jeffrylum
Merge branch 'master' of https://github.com/CS2103-AY1819S1-T09-3/main
b25ed8f 
# Conflicts:
#	src/main/java/seedu/address/logic/commands/ConvertCommand.java
#	src/main/java/seedu/address/logic/commands/ExampleCommand.java
@benedictcss benedictcss merged commit 7f0e377 into CS2103-AY1819S1-T09-3:master Nov 8, 2018
@j-lum j-lum added the severity.High A flaw that affects most users and causes major problems for users label Nov 8, 2018
@j-lum j-lum added this to the v1.4 milestone Nov 8, 2018
j-lum pushed a commit that referenced this pull request Nov 8, 2018
@benedictcss
Merge pull request #169 from j-lum/master
df8c678 
!!!Breaking changes multiple features!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
severity.High A flaw that affects most users and causes major problems for users
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@j-lum @coveralls @benedictcss @jeffrylum