Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of auto-login #235

Merged
merged 3 commits into from
Nov 16, 2018
Merged

removal of auto-login #235

merged 3 commits into from
Nov 16, 2018

Conversation

chivent
Copy link

@chivent chivent commented Nov 16, 2018

since testers are apparently not used to being auto redirected to log in, will remove this feature instead.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 589

  • 11 of 21 (52.38%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 85.505%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/commands/LoginCommand.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/google/GoogleRefreshCommand.java 2 3 66.67%
src/main/java/seedu/address/logic/commands/google/GoogleUploadCommand.java 2 4 50.0%
src/main/java/seedu/address/logic/commands/google/GoogleDlCommand.java 2 5 40.0%
src/main/java/seedu/address/logic/commands/google/GoogleLsCommand.java 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/logic/commands/google/GoogleDlCommand.java 2 70.59%
src/main/java/seedu/address/logic/commands/google/GoogleLsCommand.java 2 50.0%
src/main/java/seedu/address/logic/commands/google/GoogleRefreshCommand.java 2 36.36%
Totals Coverage Status
Change from base Build 587: -0.1%
Covered Lines: 2041
Relevant Lines: 2387

💛 - Coveralls

@chivent chivent merged commit 1db6fa1 into CS2103-AY1819S1-T09-3:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants