allow search for all fields including tags #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little hacky because I created another overloading method to allow for comparisons of other fields without disrupting the current methods and qualifiers. Do let me know if there are better ways to do this!
|
Will try and implement the cmd parameter idea and write test cases to improve coverage. |
the current flow is: 1. if there’s a specified parameter, search by that parameter only 2. search by exact name 3. search all fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little hacky because I created another overloading method to allow
for comparisons of other fields without disrupting the current methods
and qualifiers. Do let me know if there are better ways to do this! The "cmd" parameter can actually be useful for better filters. ie Instead of "find 1", "cmd" can be "priority" as in "find priority 1".