New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback for code quality of A0126633J #62

Closed

z11i opened this issue Oct 28, 2016 · 0 comments

Assignees

z11i commented Oct 28, 2016

main

Write header methods for classes and methods.
Good that logger is used. Can let your teammates make use of it as well.
Note the format
Generally good SLAP
Comment wording: "overloads"

KhooDesmond self-assigned this

KhooDesmond added a commit that referenced this issue


          Fix #62

ba2e00d

KhooDesmond mentioned this issue

Refactor test cases #78

Merged

KhooDesmond closed this as completed in #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment