Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid Twitter usernames are not allows by searchtwitter command #109

Closed
nus-se-pr-bot opened this issue Apr 7, 2018 · 2 comments
Closed

Valid Twitter usernames are not allows by searchtwitter command #109

nus-se-pr-bot opened this issue Apr 7, 2018 · 2 comments
Assignees
@KevinChuangCH
Labels
response.Accepted Acceptance of a bug type.FunctionalityBug Something isn't working

Comments

@nus-se-pr-bot
Copy link

Special character "_" (underscore) is allowed in Twitter usernames but not allowed by searchtwitter command

[original: nus-cs2103-AY1718S2/pe-round1#347]

Issue created by: @eldon-chung
@Nethergale Nethergale added the type.FunctionalityBug Something isn't working label Apr 8, 2018
@KevinChuangCH
Copy link

KevinChuangCH commented Apr 11, 2018 •
edited
Loading

@eldon-chung
Thanks for the feedback, will include underscore into the checks.

@KevinChuangCH KevinChuangCH mentioned this issue Apr 11, 2018
Merged
@KevinChuangCH
Copy link

Resolved in PR #124

@KevinChuangCH KevinChuangCH self-assigned this Apr 14, 2018
@Nethergale Nethergale added the response.Accepted Acceptance of a bug label Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinChuangCH KevinChuangCH

Labels
response.Accepted Acceptance of a bug type.FunctionalityBug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nus-se-pr-bot @KevinChuangCH @Nethergale