Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct username check #124

Merged

Conversation

KevinChuangCH
Copy link

No description provided.

…SERNAME_CONSTRAINTS to facilitate checking of input username in the search feature.
… to check for validation of input username in search function.
@KevinChuangCH
Copy link
Author

KevinChuangCH commented Apr 11, 2018

In respond to issue #109.
Allow underscore ("_")to pass the validation check.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 168

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.268%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/ParserUtil.java 0 2 0.0%
Totals Coverage Status
Change from base Build 165: 0.0%
Covered Lines: 1830
Relevant Lines: 2050

💛 - Coveralls

@KevinChuangCH KevinChuangCH merged commit 4b7d470 into CS2103JAN2018-F12-B3:master Apr 11, 2018
@Nethergale Nethergale added this to the v1.5rc milestone Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants