-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge user and question microservices #33
Merged
iynixil
merged 59 commits into
CS3219-AY2425S1:merged-user-question
from
iynixil:merge-user-question
Oct 2, 2024
Merged
Merge user and question microservices #33
iynixil
merged 59 commits into
CS3219-AY2425S1:merged-user-question
from
iynixil:merge-user-question
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch_xl Make changes according to coding standard
New action column for editting that data's row
Update data for question-service
add new button to delete for each row backend delete based on id
Delete function
format and styling for action buttons
add button to return to add question view
…ranch-tsu Display selected question's details
…ranch_xl Add scroll back to top for edit button
…ranch_xl Handle duplicate question title
…ranch-tsu Extract question routes to reduce clutter
xuelinglow
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and lgtm
whitesnowx
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this merging of services is built upon
user-service
branchfetch this PR changes onto local repo: (since its not pushed into the
merge-user-question
branch yet)git fetch upstream pull/33/head:<branch name>
git checkout <branch name>
this creates a new branch in your local repo with the
<branch name>
to view this PR's changesChanges:
change file structure of
backend/
:controller
androutes
foldersbackend/
e.gfirebase.js
backend/package.json
,npm start
wasnode index.js
, nownpm start
isnodemon index.js
change file structure of
frontend/
:my-app/
->frontend/
frontend/src/pages/
, pages separated by microservicestyles
andutils
folderstyles
for.css
files,utils
for storing utility functions (can deleteutils
at the end of project before submission if not used)frontend/src/components
components
hasstyles
folder for.css
filesgeneral:
Author(s):
to include names of people who created most of the functionality used in the file. makes it easier to write individual contribution later on.css
files are conflicting with each otherif there are issues with functionality/etc, can let me know