Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store collaboration session data to database with interval backup #75

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Store collaboration session data to database with interval backup #75

merged 11 commits into from
Oct 25, 2024

Conversation

whitesnowx
Copy link

#58

interval set to 5second

@whitesnowx whitesnowx self-assigned this Oct 24, 2024
tsulim
tsulim reviewed Oct 25, 2024
View reviewed changes
Copy link

@tsulim tsulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm just some changes to be reviewed/made 👍

frontend/src/components/CodeEditor.js Show resolved Hide resolved
backend/collaboration-service/handler/socketHandler.js Outdated Show resolved Hide resolved
@whitesnowx whitesnowx marked this pull request as draft October 25, 2024 10:17
@whitesnowx whitesnowx marked this pull request as ready for review October 25, 2024 10:32
tsulim
tsulim approved these changes Oct 25, 2024
View reviewed changes
Copy link

@tsulim tsulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tsulim tsulim merged commit ad0d77e into CS3219-AY2425S1:collaboration-service Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsulim tsulim tsulim approved these changes

Assignees

@whitesnowx whitesnowx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitesnowx @tsulim