Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reaction test to assessment #46

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Added reaction test to assessment #46

merged 7 commits into from
Mar 7, 2024

Conversation

czhang771
Copy link
Contributor

@czhang771 czhang771 commented Mar 5, 2024

Added ReactionTest to Assessment Page

♻️ Current situation & Problem

Contributed another assessment to the assessment page.

⚙️ Release Notes

Added ReactionTime Assessment on the Assessment Page with one attempt and connected it to the result visualization.

📚 Documentation

Utilized ReactionTime from ResearchKit.
Screenshot 2024-03-06 at 1 53 32 pm Screenshot 2024-03-06 at 1 53 19 pm

✅ Testing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0.86207% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 31.30%. Comparing base (77422af) to head (f98827e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   32.50%   31.30%   -1.20%     
==========================================
  Files          53       54       +1     
  Lines        2825     2937     +112     
==========================================
+ Hits          918      919       +1     
- Misses       1907     2018     +111     
Files Coverage Δ
PICS/Assessment/ResultsViz.swift 0.00% <0.00%> (ø)
PICS/Assessment/Assessments.swift 4.48% <2.09%> (-0.75%) ⬇️
PICS/Assessment/ReactionTime.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77422af...f98827e. Read the comment docs.

@YurenSUN YurenSUN self-requested a review March 6, 2024 22:10
Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and also works on my simulator

@czhang771 czhang771 merged commit 501b616 into main Mar 7, 2024
7 checks passed
@czhang771 czhang771 deleted the reactiontest branch March 7, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants