Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for Scheduler and Questionnaires #59

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Conversation

karansoin
Copy link
Contributor

@karansoin karansoin commented Mar 13, 2024

Final Tests and Code Refinement - Scheduler & Questionnaires

♻️ Current situation & Problem

  • Current code coverage for Questionnaires/Spezi Scheduler before this PR was at approx 55%
  • Code was not fully commented and refined
  • Unnecessary commented out code was still in certain code files

⚙️ Release Notes

  • Added UI and Unit tests covering majority of Questionnaire/Scheduler files
  • Cleaned up unnecessary commented out code and refined comments explaining code and logic

📚 Documentation

  • Code and testing logic and documentation in the comments for the tests
  • Used the updated XCTSpezi package
  • Added tests to improve code coverage to over 75%

✅ Testing

  • Code Coverage is now 86%+ after this PR
  • Testing covers more than 75% of Scheduler and Questionnaires lines
  • Covers both UI and Unit Testing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (ef56301) to head (e8625ad).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   82.26%   86.21%   +3.96%     
==========================================
  Files          54       54              
  Lines        2987     2987              
==========================================
+ Hits         2457     2575     +118     
+ Misses        530      412     -118     
Files Coverage Δ
PICS/Schedule/PICSScheduler.swift 100.00% <100.00%> (+19.24%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef56301...e8625ad. Read the comment docs.

Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@karansoin karansoin merged commit d8a2dca into main Mar 14, 2024
7 checks passed
@karansoin karansoin deleted the FINAL-Karan-changes branch March 14, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants