Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Revoke limit on HealthKit Query #61

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Bug fix: Revoke limit on HealthKit Query #61

merged 2 commits into from
Mar 14, 2024

Conversation

YurenSUN
Copy link
Contributor

@YurenSUN YurenSUN commented Mar 14, 2024

Bug fix: Revoke limit on HealthKit Query

♻️ Current situation & Problem

Previously, we set a limit on how many data samples to query for debugging. This causes that insufficient data to display and we want to revoke it.

⚙️ Release Notes

  • remove the limit in the HKSampleQuery

📚 Documentation

Not related.

✅ Testing

Tested on simulator

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@YurenSUN YurenSUN marked this pull request as ready for review March 14, 2024 03:05
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (d8a2dca) to head (0dda18d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          54       54           
  Lines        2987     2987           
=======================================
  Hits         2575     2575           
  Misses        412      412           
Files Coverage Δ
PICS/HealthVisulization/HKVisualization.swift 77.42% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a2dca...0dda18d. Read the comment docs.

@YurenSUN YurenSUN enabled auto-merge (squash) March 14, 2024 03:52
Copy link
Contributor

@akanshyabhat akanshyabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@YurenSUN YurenSUN merged commit 35e98bf into main Mar 14, 2024
7 checks passed
@YurenSUN YurenSUN deleted the hk-fix-addition branch March 14, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants