Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for handover #62

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Cleanup for handover #62

merged 9 commits into from
Mar 19, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Mar 19, 2024

Cleanup for handover

⚙️ Release Notes

  • Minor adjustments within the app to have it ready for handover.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg changed the title Initial assessment cleanup Cleanup for handover Mar 19, 2024
@Supereg Supereg marked this pull request as draft March 19, 2024 01:00
@Supereg Supereg marked this pull request as ready for review March 19, 2024 05:07
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 88.24343% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 84.97%. Comparing base (33404b4) to head (e33040a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   83.06%   84.97%   +1.91%     
==========================================
  Files          54       52       -2     
  Lines        2987     2654     -333     
==========================================
- Hits         2481     2255     -226     
+ Misses        506      399     -107     
Files Coverage Δ
PICS/Account/AccountSetupHeader.swift 100.00% <ø> (ø)
PICS/Account/AccountSheet.swift 95.66% <ø> (ø)
PICS/Appointment/Appointments.swift 100.00% <100.00%> (ø)
PICS/Appointment/GettingThere.swift 100.00% <100.00%> (ø)
PICS/Appointment/TimelineView.swift 98.14% <100.00%> (+0.02%) ⬆️
PICS/Assessment/Assessments.swift 100.00% <100.00%> (+0.48%) ⬆️
PICS/Assessment/Model/AssessmentResult.swift 100.00% <100.00%> (ø)
PICS/Assessment/Model/AssessmentResults.swift 100.00% <100.00%> (ø)
PICS/HealthVisulization/HKVisualization.swift 77.18% <100.00%> (-0.24%) ⬇️
PICS/HealthVisulization/HKVisualizationItem.swift 96.30% <100.00%> (-0.07%) ⬇️
... and 31 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33404b4...e33040a. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 955fd37 into main Mar 19, 2024
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the cleanup branch March 19, 2024 07:46
@PSchmiedmayer
Copy link
Member

Thank you @Supereg! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants