-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[+] Basic view of our GUI #20
Conversation
ʕ•̫͡•ʕ•̫͡•ʔ•̫͡•ʔ•̫͡•ʕ•̫͡•ʔ•̫͡•ʕ•̫͡•ʕ•̫͡•ʔ•̫͡•ʔ•̫͡•ʕ•̫͡•ʔ•̫͡•ʔ |
Lab要迟到啦QAQ |
Add register functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, to simplify our work, I suggest we can combine login and register. We only need a user name and a password to login and register. If the user does not exist in our database, then we automatically register this user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have too much technical comments on the specific implementations of the GUI, but some minor problems are spotted, and most are mentioned by Scott's review.
But overall, the GUI is looking pretty good! However, we might need to consider to switch to Scott's proposal as I believe that works better for our purposes (And maybe easier to implement?)
So, we don't need the user to confirm their password when he/she tries to register? |
Add a resource image for the back button
Redraw the image for backIcon to make it consistent with the GUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great!
There are some style/convention issues that need to be fixed.
TODOs:
- Add username and password checks.
- Actions that should be performed after signing out.
- Fix convention issues.
- Make the text area not editable.
- Change the look and feel of the text area like its font.
- Add menu bar.
- After adding the menu bar: @eevadai : Incorperate your work done into the new GUI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think the new GUI looks pretty good! (From Scott's picture)
I still can't get it looking like normal on my Mac XD
The disabled buttons looks completely White, the "Back" button icon is gray for some reasons.
Just something to consider:
Do we want to consider the "resizability" of the Window / Frame? (E.g. getting a 1000 * 618 Window on a 4k screen would be pretty sad)
If yes, then maybe we have to remove some of the "Magic number" code smell I have identified earlier. For example, the sizes of the headers and menu bar.
Anyways, good job! The GUI Wise implementation is pretty good looking already!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems mentioned resolved
GOOD JOB!
New feature