Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[*] Improved the add entry dialog and added support for splitter entry. #90

Merged
merged 1 commit into from
Dec 5, 2022
Merged

[*] Improved the add entry dialog and added support for splitter entry. #90

merged 1 commit into from
Dec 5, 2022

Conversation

Ellen141319
Copy link
Contributor

[*] Fixed some bugs.

Lei-Tin
Lei-Tin approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@Lei-Tin Lei-Tin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Small issue with the currency part though.
And also small alignment issue.

src/main/java/billgates/view/BillGatesUtilities.java Show resolved Hide resolved
src/main/java/billgates/view/gui/AddEntryDialog.java

this.add(new ActionLabel("Description:"));
this.descriptionField = new ActionTextField(20);
this.add(this.descriptionField);
Copy link
Collaborator

@Lei-Tin Lei-Tin Dec 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to this.___.setAlignmentX(LEFT_ALIGNMENT)on everything else?

image

The right hand side is the example where I added LEFT_ALIGNMENT to everything, looks a little bit cleaner IMO? (If we don't add LEFT_ALIGNMENT to everything, it is like a few pixels off, refer to the light blue lines above)

@ScottCTD ScottCTD added the enhancement New feature or request label Dec 5, 2022
ScottCTD
ScottCTD approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@ScottCTD ScottCTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future TODO:

  • Add a use case to get the parent entry data to fill the inherited attributes in a splitter entry.

src/main/java/billgates/view/gui/AddEntryDialog.java

this.result = JOptionPane.showConfirmDialog(this, insertEntryDialog,
"Information about the new entry", JOptionPane.OK_CANCEL_OPTION, JOptionPane.PLAIN_MESSAGE);
initDialog();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convention: Add this. before using an instance method.

@ScottCTD ScottCTD merged commit d491129 into main Dec 5, 2022
@ScottCTD ScottCTD deleted the ellen_2 branch December 5, 2022 14:06
@ScottCTD ScottCTD linked an issue Dec 5, 2022 that may be closed by this pull request
[Feature] Add support for adding a splitter entry. #80
Closed
@Ellen141319 Ellen141319 mentioned this pull request Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottCTD ScottCTD ScottCTD approved these changes

@Lei-Tin Lei-Tin Lei-Tin approved these changes

Assignees

@Ellen141319 Ellen141319

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for adding a splitter entry.
3 participants
@Ellen141319 @Lei-Tin @ScottCTD