FIX Config file creation may fail if its parent directory (app_config_dir) doesn't exist. #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h. Simply using std::fs::File::create will fail in this case.
✔️ Deskulpt Built Successfully!Deskulpt binaries have been built successfully on all supported platforms. Your pull request is in excellent shape! You may check the built Deskulpt binaries here and download them to test locally. Workflow file: |
Charlie-XIAO
approved these changes
Dec 12, 2024
Comment on lines
+70
to
+72
| // On certain platform, if the file directory does not exist, file creation using std::fs:;File::create will fail. | ||
| // See [the doc](https://doc.rust-lang.org/std/fs/struct.File.html#method.create) for detail. | ||
| // Thus we need to manually create app_config_dir if it doesn't exist. |
There was a problem hiding this comment.
Suggested change
| // On certain platform, if the file directory does not exist, file creation using std::fs:;File::create will fail. | |
| // See [the doc](https://doc.rust-lang.org/std/fs/struct.File.html#method.create) for detail. | |
| // Thus we need to manually create app_config_dir if it doesn't exist. | |
| // On certain platform, if the file directory does not exist, file creation using | |
| // std::fs::File::create will fail. Thus we need to manually create app_config_dir | |
| // if it doesn't exist. |
rustfmt seems not to warn against excessively long comment lines (at least not with the current configuration 🤔) but let's still obey the 88-column rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is described in the title.