Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting the project (Readme) and it's behaviour (Diagrams) #13

Merged
merged 12 commits into from
Apr 8, 2024
Merged

Documenting the project (Readme) and it's behaviour (Diagrams) #13

merged 12 commits into from
Apr 8, 2024

Conversation

telliere
Copy link
Collaborator

@telliere telliere commented Mar 25, 2024 •
edited
Loading

  • Readme

    • Quickstart
      • Client
      • Server
    • Limitations

  • CLI

  • Architecture

    • Global Architecture
    • Sequence Diagrams
      • Data preparation
      • Container preparation
      • Job preparation
    • Token lifecycle - Permissions

@telliere telliere force-pushed the doc/readme_and_sequence_diagrams branch 2 times, most recently from 267eb5a to 44511ae Compare March 27, 2024 07:52
@mmatthiesencsc
Copy link
Collaborator

Hi Emilien, thanks a lot for this very detailed documentation, really good work! I suggest we have a quick look through it face2face, but please feel free to accept the suggestions that are easy to accept and don't need discussion.

@telliere
Copy link
Collaborator Author

I don't have any suggestion on the PR

@telliere telliere force-pushed the doc/readme_and_sequence_diagrams branch from 44511ae to 180c3cd Compare March 27, 2024 11:17
@telliere telliere self-assigned this Mar 27, 2024
mmatthiesencsc
mmatthiesencsc requested changes Mar 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture/container_preparation.md Show resolved Hide resolved
docs/architecture/container_preparation.md Show resolved Hide resolved
docs/architecture/container_preparation.md Show resolved Hide resolved
@telliere @mmatthiesencsc
applying typos / orthogrphic / sentence issues in existing documentation
f06f4da 
Co-authored-by: Martin Matthiesen <martin.matthiesen@csc.fi>
@telliere
Copy link
Collaborator Author

Thank you very much for the review @mmatthiesencsc. Really valuable to me. Applied every recommandations after reviewing them

@telliere telliere force-pushed the doc/readme_and_sequence_diagrams branch 2 times, most recently from 818b1b3 to 0d11984 Compare April 2, 2024 14:18
@telliere telliere force-pushed the doc/readme_and_sequence_diagrams branch from 0d11984 to 10fb241 Compare April 3, 2024 06:58
@telliere
Copy link
Collaborator Author

telliere commented Apr 5, 2024

Last bits of documentation are here, a last review should allow us to merge this branch @mmatthiesencsc

mmatthiesencsc
mmatthiesencsc approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@mmatthiesencsc mmatthiesencsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emilien, merging as last state of your efforts this time. I have not yet tested the installation.

@mmatthiesencsc mmatthiesencsc merged commit 932ddfe into main Apr 8, 2024
5 checks passed
@mmatthiesencsc mmatthiesencsc deleted the doc/readme_and_sequence_diagrams branch April 8, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatthiesencsc mmatthiesencsc mmatthiesencsc approved these changes

Assignees

@telliere telliere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@telliere @mmatthiesencsc