Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF improvements #2116

Merged
merged 10 commits into from
Apr 20, 2020
Merged

PDF improvements #2116

merged 10 commits into from
Apr 20, 2020

Conversation

opqdonut
Copy link
Contributor

@opqdonut opqdonut commented Apr 8, 2020 •
edited
Loading

for #2114

Definition of Done / Review checklist

Reviewability

  • link to issue
  • consider adding screenshots for ease of review

Documentation

  • update changelog if necessary

Testing

  • valuable features are integration / browser / acceptance tested automatically

Follow-up

  • no critical TODOs left to implement

@opqdonut
Copy link
Contributor Author

opqdonut commented Apr 8, 2020

example-application.pdf

@opqdonut
deps: upgrade clj-pdf
5b6f2f6
@opqdonut
refactor: simplify pdf generation a bit
4529c4a 
now that clj-pdf has better support for lists inside elements
@opqdonut
Copy link
Contributor Author

there's a conflict in the changelog but it's less work to fix it after #2108 is in

@opqdonut opqdonut merged commit 0628b49 into master Apr 20, 2020
@opqdonut opqdonut deleted the pdf-improvements-2114 branch April 20, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Macroz Macroz Macroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opqdonut @Macroz