improvements to event notifications & docs #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by roundtripping events via the db before giving them to process managers
Macroz
approved these changes
Apr 21, 2020
resources/sql/queries.sql
Outdated
| @@ -485,9 +485,10 @@ FROM application_event | |||
| ORDER BY id DESC | |||
| LIMIT 1; | |||
|
|
|||
| -- :name add-application-event! :insert | |||
| -- :name add-application-event! :? :1 | |||
There was a problem hiding this comment.
How about using :returning-execute here. This doesn't seem to be correct.
https://www.hugsql.org/#retrieving-last-inserted-id-or-record
There was a problem hiding this comment.
I had some weird sql problems and was iterating stuff, this got left over from that I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #2095
Definition of Done / Review checklist
Reviewability
Documentation
Testing
Follow-up