Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow handler to redact handler attachments #3189

Merged
merged 25 commits into from
Oct 12, 2023
Merged

Conversation

aatkin
Copy link
Collaborator

@aatkin aatkin commented Sep 28, 2023

relates #3190

Allow handler to redact also other handler attachments. Refactored model/allowed-redact-roles and model/apply-attachment-permissions, and amended api test with test case where handler redacts another handlers attachment.

Other changes

  • handling users may now see which attachments were redacted in event/redacted-attachments

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review

Backwards compatibility

  • Feature appears correctly in PDF print

Documentation

  • Update changelog if necessary

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

  • New tasks are created for pending or remaining tasks

Screenshots

Handler

Screenshot 2023-10-05 at 19 15 31

Screenshot 2023-10-05 at 19 19 23

Applicant

Screenshot 2023-10-05 at 19 16 18

Screenshot 2023-10-05 at 19 18 53

src/cljc/rems/common/application_util.cljc Outdated Show resolved Hide resolved
(or (:attachment/redacted attachment)
(not event-id))
false
already-redacted false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice naming 👍

@aatkin aatkin marked this pull request as ready for review September 29, 2023 11:08
@aatkin aatkin mentioned this pull request Oct 12, 2023
2 tasks
@aatkin aatkin merged commit b69abf2 into master Oct 12, 2023
7 checks passed
@aatkin aatkin deleted the handler-redaction-fix branch October 12, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants